Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2260763002: Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests. (Closed)

Created:
4 years, 4 months ago by Shanmuga Pandi
Modified:
4 years, 4 months ago
Reviewers:
Srirama, fs, foolip
CC:
blink-reviews, chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests. BUG=636710 Committed: https://crrev.com/bf240bb3b943e22236a094511e52e4bf778b0e6b Cr-Commit-Position: refs/heads/master@{#413715}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Align with review comments #

Total comments: 21

Patch Set 3 : Align with review comments #

Total comments: 6

Patch Set 4 : Align with review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -466 lines) Patch
M third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js View 1 2 1 chunk +14 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/select-svg-text-with-collapsed-whitespace.html View 1 2 2 chunks +36 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/text/select-svg-text-with-collapsed-whitespace-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html View 1 2 2 chunks +20 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html View 1 2 2 chunks +18 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html View 1 2 2 chunks +18 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html View 1 2 3 1 chunk +85 lines, -92 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html View 1 2 1 chunk +45 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/text/text-rect-precision-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (5 generated)
Shanmuga Pandi
PTAL!!
4 years, 4 months ago (2016-08-19 07:50:13 UTC) #2
Shanmuga Pandi
On 2016/08/19 07:50:13, Shanmuga Pandi wrote: > PTAL!! This patch is prepared , before the ...
4 years, 4 months ago (2016-08-19 07:51:15 UTC) #3
Srirama
https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html (right): https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html#newcode20 third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:20: function getEndPosition(id, offset, gap) { give indentation for all ...
4 years, 4 months ago (2016-08-19 11:42:14 UTC) #4
Shanmuga Pandi
PTAL!! https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html (right): https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html#newcode20 third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:20: function getEndPosition(id, offset, gap) { On 2016/08/19 11:42:14, ...
4 years, 4 months ago (2016-08-22 06:40:34 UTC) #5
Srirama
lgtm
4 years, 4 months ago (2016-08-22 08:43:34 UTC) #6
Shanmuga Pandi
PTAL!
4 years, 4 months ago (2016-08-22 13:24:33 UTC) #8
fs
https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js File third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js (right): https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js#newcode148 third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js:148: assert_equals(startElementId, expected.startElementId); In general I think it'd be preferable ...
4 years, 4 months ago (2016-08-22 14:10:06 UTC) #9
Shanmuga Pandi
PTAL! https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js File third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js (right): https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js#newcode148 third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js:148: assert_equals(startElementId, expected.startElementId); On 2016/08/22 14:10:05, fs wrote: > ...
4 years, 4 months ago (2016-08-23 07:11:38 UTC) #10
fs
https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html File third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html (right): https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html#newcode24 third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:24: expectedTestPoint = expectedPoint; These should go too. Use the ...
4 years, 4 months ago (2016-08-23 08:30:11 UTC) #11
Shanmuga Pandi
https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html File third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html (right): https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html#newcode103 third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:103: document.documentElement.removeChild(svgRoot); On 2016/08/23 08:30:11, fs wrote: > Just leave ...
4 years, 4 months ago (2016-08-23 08:57:33 UTC) #12
fs
On 2016/08/23 at 08:57:33, shanmuga.m wrote: > https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html > File third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html (right): > > https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html#newcode103 ...
4 years, 4 months ago (2016-08-23 09:03:36 UTC) #13
Shanmuga Pandi
PTAL https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html File third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html (right): https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html#newcode24 third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:24: expectedTestPoint = expectedPoint; On 2016/08/23 08:30:11, fs wrote: ...
4 years, 4 months ago (2016-08-23 09:22:09 UTC) #14
fs
lgtm
4 years, 4 months ago (2016-08-23 10:27:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260763002/60001
4 years, 4 months ago (2016-08-23 10:27:59 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-23 11:44:51 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 11:46:30 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bf240bb3b943e22236a094511e52e4bf778b0e6b
Cr-Commit-Position: refs/heads/master@{#413715}

Powered by Google App Engine
This is Rietveld 408576698