Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests.

Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests.

BUG=636710
Committed: https://crrev.com/bf240bb3b943e22236a094511e52e4bf778b0e6b
Cr-Commit-Position: refs/heads/master@{#413715}

[Shanmuga Pandi, 2016-08-19 07:50:13]

shanmuga.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Shanmuga Pandi, 2016-08-19 07:50:13]

PTAL!!

[Shanmuga Pandi, 2016-08-19 07:51:15]

On 2016/08/19 07:50:13, Shanmuga Pandi wrote:
> PTAL!!

This patch is prepared , before the fs@ comment
https://bugs.chromium.org/p/chromium/issues/detail?id=636710#c4

I will start doing the change svg/dom/* after this..

[Srirama, 2016-08-19 11:42:14]

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html
(right):

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:20:
function getEndPosition(id, offset, gap) {
give indentation for all the code inside test function. Applies to all the
files.

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:20:
function getEndPosition(id, offset, gap) {
looks like this is common in most of the tests. So move it to
SelectionTestCase.js

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html (right):

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html:25:
assert_less_than(elementWidth, textWidth);
i think these two stmts should be assert_less_than_equal to match the original
behaviour.

[Shanmuga Pandi, 2016-08-22 06:40:34]

PTAL!!

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html
(right):

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:20:
function getEndPosition(id, offset, gap) {
On 2016/08/19 11:42:14, Srirama wrote:
> give indentation for all the code inside test function. Applies to all the
> files.

Done.

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:20:
function getEndPosition(id, offset, gap) {
On 2016/08/19 11:42:14, Srirama wrote:
> looks like this is common in most of the tests. So move it to
> SelectionTestCase.js

Done.

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html (right):

https://codereview.chromium.org/2260763002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html:25:
assert_less_than(elementWidth, textWidth);
On 2016/08/19 11:42:14, Srirama wrote:
> i think these two stmts should be assert_less_than_equal to match the original
> behaviour.

Done.

[Srirama, 2016-08-22 08:43:34]

lgtm

[Shanmuga Pandi, 2016-08-22 13:24:32]

shanmuga.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Shanmuga Pandi, 2016-08-22 13:24:33]

PTAL!

[fs, 2016-08-22 14:10:06]

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js:148:
assert_equals(startElementId, expected.startElementId);
In general I think it'd be preferable to have the assertions in the actual
test-file. But we can do that incrementally. (Test using this framework can't be
upstreamed/run in other browsers regardless.)

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/text/select-svg-text-with-collapsed-whitespace.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/select-svg-text-with-collapsed-whitespace.html:16:
if (!window.testRunner)
Could as well drop this, because we're checking eventSender already, and this
test will fail without it regardless (so first assertion will fail.)

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:35:
});
This test needs either a <title> or an explicit name specified.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html:40:
});
Ditto (like -1)

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html:35:
});
Ditto.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:2:
<title>Check that SVGTextContentElement methods' parameters are correctly
validated</title>
Drop the "Check that" for a slightly better testname.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:15:
svgText.style.visibility = "hidden";
No need to add this. Also, the SVG content could be included in the markup.
(Then if we don't want it to show we can do height=0 or so.)

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:22:
var actualTestPoint, expectedTestPoint;
You don't need these - just reference actualPoint and expectedPoint directly
instead.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:31:
var actualTestRect, expectedTestRect;
Ditto.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html (right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html:2: <title>Test
the width of text element is similar to the sum of the width of all
characters.</title>
Drop 'Test '. (I.e "The width...")

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html:27: function
measureText(testElement) {
Suggest you move this out of the test() scope.

[Shanmuga Pandi, 2016-08-23 07:11:38]

PTAL!

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/resources/SelectionTestCase.js:148:
assert_equals(startElementId, expected.startElementId);
On 2016/08/22 14:10:05, fs wrote:
> In general I think it'd be preferable to have the assertions in the actual
> test-file. But we can do that incrementally. (Test using this framework can't
be
> upstreamed/run in other browsers regardless.)

Acknowledged.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/text/select-svg-text-with-collapsed-whitespace.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/select-svg-text-with-collapsed-whitespace.html:16:
if (!window.testRunner)
On 2016/08/22 14:10:05, fs wrote:
> Could as well drop this, because we're checking eventSender already, and this
> test will fail without it regardless (so first assertion will fail.)

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-1.html:35:
});
On 2016/08/22 14:10:05, fs wrote:
> This test needs either a <title> or an explicit name specified.

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html:40:
});
On 2016/08/22 14:10:05, fs wrote:
> Ditto (like -1)

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html:35:
});
On 2016/08/22 14:10:05, fs wrote:
> Ditto.

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html
(right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:2:
<title>Check that SVGTextContentElement methods' parameters are correctly
validated</title>
On 2016/08/22 14:10:05, fs wrote:
> Drop the "Check that" for a slightly better testname.

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:15:
svgText.style.visibility = "hidden";
On 2016/08/22 14:10:05, fs wrote:
> No need to add this. Also, the SVG content could be included in the markup.
> (Then if we don't want it to show we can do height=0 or so.)

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:22:
var actualTestPoint, expectedTestPoint;
On 2016/08/22 14:10:05, fs wrote:
> You don't need these - just reference actualPoint and expectedPoint directly
> instead.

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:31:
var actualTestRect, expectedTestRect;
On 2016/08/22 14:10:05, fs wrote:
> Ditto.

Done.

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html (right):

https://codereview.chromium.org/2260763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/text-rect-precision.html:27: function
measureText(testElement) {
On 2016/08/22 14:10:05, fs wrote:
> Suggest you move this out of the test() scope.

Done.

[fs, 2016-08-23 08:30:11]

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html
(right):

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:24:
expectedTestPoint = expectedPoint;
These should go too. Use the ones without *Test*.

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:32:
expectedTestRect = expectedRect;
Ditto.

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:103:
document.documentElement.removeChild(svgRoot);
Just leave the elements in the tree.

[Shanmuga Pandi, 2016-08-23 08:57:33]

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html
(right):

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:103:
document.documentElement.removeChild(svgRoot);
On 2016/08/23 08:30:11, fs wrote:
> Just leave the elements in the tree.

When I leave the element within tree, even with "height as 0", still "abcdefg"
appears in the actualResult. So can i add "expected-result" file also in that
case?

[fs, 2016-08-23 09:03:36]

On 2016/08/23 at 08:57:33, shanmuga.m wrote:
>
https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html
(right):
> 
>
https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:103:
document.documentElement.removeChild(svgRoot);
> On 2016/08/23 08:30:11, fs wrote:
> > Just leave the elements in the tree.
> 
> When I leave the element within tree, even with "height as 0", still "abcdefg"
appears in the actualResult. So can i add "expected-result" file also in that
case?

Oh, right, that sillyness... Please disregard this then.

[Shanmuga Pandi, 2016-08-23 09:22:09]

PTAL

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html
(right):

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:24:
expectedTestPoint = expectedPoint;
On 2016/08/23 08:30:11, fs wrote:
> These should go too. Use the ones without *Test*.

Done.

https://codereview.chromium.org/2260763002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html:32:
expectedTestRect = expectedRect;
On 2016/08/23 08:30:11, fs wrote:
> Ditto.

Done.

[fs, 2016-08-23 10:27:03]

lgtm

[Shanmuga Pandi, 2016-08-23 10:27:39]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-08-23 10:27:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
srirama.m@samsung.com
Link to the patchset: https://codereview.chromium.org/2260763002/#ps60001
(title: "Align with review comments")

[commit-bot: I haz the power, 2016-08-23 10:27:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 11:44:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-23 11:46:29]

Description was changed from

==========
Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests.

BUG=636710
==========

to

==========
Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests.

BUG=636710

Committed: https://crrev.com/bf240bb3b943e22236a094511e52e4bf778b0e6b
Cr-Commit-Position: refs/heads/master@{#413715}
==========

[commit-bot: I haz the power, 2016-08-23 11:46:30]

Patchset 4 (id:??) landed as
https://crrev.com/bf240bb3b943e22236a094511e52e4bf778b0e6b
Cr-Commit-Position: refs/heads/master@{#413715}