Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html

Issue 2260763002: Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align with review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html
diff --git a/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html b/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html
index 16022b4ddb1159751ac3675793d7c097fb1e7d84..082099818f4a91addcabd9ed9f6b60f0bfc0beb7 100644
--- a/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html
+++ b/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-2.html
@@ -1,4 +1,5 @@
<!DOCTYPE html>
+<title>Text Selection when dragging mouse outside the SVG text element</title>
<style>
text {
font: 10px Arial;
@@ -15,33 +16,27 @@ text {
<text id="line3" x="100" y="100">Hello World. Hello, SVG.</text>
</g>
</svg>
-<script src="../../resources/js-test.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="resources/SelectionTestCase.js"></script>
-<script type="text/javascript">
-function getEndPosition(id, offset, gap) {
- var element = document.getElementById(id);
- var endPos = element.getEndPositionOfChar(offset);
- endPos.x += gap.x;
- endPos.y += gap.y;
- var absEndPos = toAbsoluteCoordinates(endPos, element);
- return absEndPos;
-}
-
-var absEndPos = getEndPosition('line3', 10, { x : 0, y : 30});
-selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: "7", endElementId: "line3", end: "11" });
+<script>
+test(function() {
+ var absEndPos = getEndPosition('line3', 10, { x : 0, y : 30});
+ selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: 7, endElementId: "line3", end: 11 });
-absEndPos = getEndPosition('line2', 10, { x : 0, y : 30});
-selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: "7", endElementId: "line2", end: "11" });
+ absEndPos = getEndPosition('line2', 10, { x : 0, y : 30});
+ selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: 7, endElementId: "line2", end: 11 });
-absEndPos = getEndPosition('line3', 10, { x : 0, y : 30});
-selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: "7", endElementId: "line3", end: "11" });
+ absEndPos = getEndPosition('line3', 10, { x : 0, y : 30});
+ selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: 7, endElementId: "line3", end: 11 });
-absEndPos = getEndPosition('line1', 8, { x : 0, y : -30});
-selectTextFromCharToPoint({ id: 'line3', offset: 7 }, absEndPos, { startElementId: "line3", start: "7", endElementId: "line1", end: "9" });
+ absEndPos = getEndPosition('line1', 8, { x : 0, y : -30});
+ selectTextFromCharToPoint({ id: 'line3', offset: 7 }, absEndPos, { startElementId: "line3", start: 7, endElementId: "line1", end: 9 });
-absEndPos = getEndPosition('line1', 8, { x : 0, y : -30});
-selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: "7", endElementId: "line1", end: "9" });
+ absEndPos = getEndPosition('line1', 8, { x : 0, y : -30});
+ selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: 7, endElementId: "line1", end: 9 });
-absEndPos = getEndPosition('line2', 8, { x : 0, y : -30});
-selectTextFromCharToPoint({ id: 'line3', offset: 7 }, absEndPos, { startElementId: "line3", start: "7", endElementId: "line2", end: "9" });
+ absEndPos = getEndPosition('line2', 8, { x : 0, y : -30});
+ selectTextFromCharToPoint({ id: 'line3', offset: 7 }, absEndPos, { startElementId: "line3", start: 7, endElementId: "line2", end: 9 });
+});
</script>

Powered by Google App Engine
This is Rietveld 408576698