Remove ContentSuggestionsProvider::GetProvidedCategories().

Remove ContentSuggestionsProvider::GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(),
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
Committed: https://crrev.com/47a8bf5b772e8b3f50e67791c1c2990a12004158
Cr-Commit-Position: refs/heads/master@{#413428}

[vitaliii, 2016-08-19 13:42:22]

vitaliii@chromium.org changed reviewers:
+ pke@google.com

[vitaliii, 2016-08-19 13:42:23]

Please have a look.

[Philipp Keck, 2016-08-19 14:14:13]

See comments below, otherwise lgtm.

"ContentSuggestionsProvider::" could be added to the issue description, so that
the reader knows what the commit is roughly about.

s/need in/need for/

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_provider.h (left):

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_provider.h:89: virtual
std::vector<Category> GetProvidedCategories() = 0;
Please search your new code for "GetProvidedCategories". There's at least this
occurrence:
https://codesearch.chromium.org/chromium/src/components/ntp_snippets/content_...

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service_unittest.cc (right):

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service_unittest.cc:94:
observer()->OnCategoryStatusChanged(this, category,
Couldn't this just go in the RegisterProvider method instead of being a separate
method that every test needs to call?

[vitaliii, 2016-08-19 16:13:11]

Description was changed from

==========
Remove GetProvidedCategories().

Since there is OnCategoryStatusChanged(), there is no need in
GetProvidedCategories().

BUG=639282
==========

to

==========
Remove GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(),
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

[vitaliii, 2016-08-19 16:13:31]

Description was changed from

==========
Remove GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(),
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

to

==========
Remove GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(), 
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

[vitaliii, 2016-08-19 16:14:14]

vitaliii@chromium.org changed reviewers:
+ treib@chromium.org

[vitaliii, 2016-08-19 16:14:15]

Hello trieb,

Please review a changelist.

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_provider.h (left):

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_provider.h:89: virtual
std::vector<Category> GetProvidedCategories() = 0;
On 2016/08/19 14:14:13, Philipp Keck wrote:
> Please search your new code for "GetProvidedCategories". There's at least this
> occurrence:
>
https://codesearch.chromium.org/chromium/src/components/ntp_snippets/content_...

Done.

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service_unittest.cc (right):

https://codereview.chromium.org/2260703004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service_unittest.cc:94:
observer()->OnCategoryStatusChanged(this, category,
On 2016/08/19 14:14:13, Philipp Keck wrote:
> Couldn't this just go in the RegisterProvider method instead of being a
separate
> method that every test needs to call?

Then it is not possible to do ShouldRegisterNewCategoryOnNewSuggestions test,
which requires not to notify.

[Marc Treib, 2016-08-19 16:23:18]

Philipp's comment about the description still applies: Please make it a bit more
specific by adding "ContentSuggestionsProvider::".
Otherwise lgtm :)

[vitaliii, 2016-08-19 16:28:56]

Description was changed from

==========
Remove GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(), 
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

to

==========
Remove ContentSuggestionsProvider::GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(), 
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

[vitaliii, 2016-08-22 08:04:37]

The CQ bit was checked by vitaliii@chromium.org

[vitaliii, 2016-08-22 08:04:37]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
pke@google.com
Link to the patchset: https://codereview.chromium.org/2260703004/#ps20001
(title: "Philipp's comments and rebase.")

[commit-bot: I haz the power, 2016-08-22 08:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 10:08:55]

Description was changed from

==========
Remove ContentSuggestionsProvider::GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(), 
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

to

==========
Remove ContentSuggestionsProvider::GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(), 
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

[commit-bot: I haz the power, 2016-08-22 10:08:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 10:10:50]

Description was changed from

==========
Remove ContentSuggestionsProvider::GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(), 
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282
==========

to

==========
Remove ContentSuggestionsProvider::GetProvidedCategories().

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(),
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282

Committed: https://crrev.com/47a8bf5b772e8b3f50e67791c1c2990a12004158
Cr-Commit-Position: refs/heads/master@{#413428}
==========

[commit-bot: I haz the power, 2016-08-22 10:10:50]

Patchset 2 (id:??) landed as
https://crrev.com/47a8bf5b772e8b3f50e67791c1c2990a12004158
Cr-Commit-Position: refs/heads/master@{#413428}