components/ntp_snippets/ntp_snippets_service.cc - Issue 2260703004: Remove ContentSuggestionsProvider::GetProvidedCategories().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2260703004: Remove ContentSuggestionsProvider::GetProvidedCategories(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Philipp's comments and rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.h ('k') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index 59769433d57c3dceca775fd3fabcdee9af2c8d90..282c5d9765c0bd9ab31306e02dc9bb735ae968bb 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -216,6 +216,7 @@ NTPSnippetsService::NTPSnippetsService(

thumbnail_requests_throttler_(

pref_service,

RequestThrottler::RequestType::CONTENT_SUGGESTION_THUMBNAIL) {

+ observer->OnCategoryStatusChanged(this, provided_category_, category_status_);

if (database_->IsErrorState()) {

EnterState(State::ERROR_OCCURRED, CategoryStatus::LOADING_ERROR);

return;

@@ -275,10 +276,6 @@ void NTPSnippetsService::RescheduleFetching() {

}

-std::vector<Category> NTPSnippetsService::GetProvidedCategories() {

- return std::vector<Category>({provided_category_});

CategoryStatus NTPSnippetsService::GetCategoryStatus(Category category) {

DCHECK(category.IsKnownCategory(KnownCategories::ARTICLES));

return category_status_;