runtime/vm/dart_api_impl.cc - Issue 22607005: Remove race(s) in vmservice tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 22607005: Remove race(s) in vmservice tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index c4410a529d83ac4b73f3dec1f90f943c41e0abd8..fddab02a30ec1c786c4c97fcf0a974897655f9bf 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -827,6 +827,7 @@ DART_EXPORT void* Dart_CurrentIsolateData() {

DART_EXPORT Dart_Handle Dart_DebugName() {

Isolate* isolate = Isolate::Current();

CHECK_ISOLATE(isolate);

+ DARTSCOPE(isolate);

Ivan Posva 2013/08/07 23:33:38 DARTSCOPE does include CHECK_ISOLATE, so you can d

Cutch 2013/08/08 14:26:39 Done.

return Api::NewHandle(isolate, String::New(isolate->name()));

}