Remove race(s) in vmservice tests.

runtime/bin/main.cc

Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index b1d60ee88fe2f04621cb4e1c6daf5781dbc152e8..6ff7113c4d381e3be21739f1310583acfe197a7d 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -500,8 +500,6 @@ static Dart_Isolate CreateIsolateAndSetupHelper(const char* script_uri,
     return NULL;
   }
 
-  VmService::SendIsolateStartupMessage(Dart_GetMainPortId());
-
   // Make the isolate runnable so that it is ready to handle messages.
   Dart_ExitScope();
   Dart_ExitIsolate();
@@ -513,6 +511,16 @@ static Dart_Isolate CreateIsolateAndSetupHelper(const char* script_uri,
     return NULL;
   }
 
+  Dart_EnterIsolate(isolate);

[Ivan Posva, 2013/08/07 23:33:38]

You cannot enter the isolate after having made it runnable. Suddenly two threads
will execute concurrently within one isolate. You need to get the name before
making the isolate runnable.

[Cutch, 2013/08/08 14:26:39]

Done.

+  Dart_EnterScope();
+
+  Dart_Handle debug_name = Dart_DebugName();
+  CHECK_RESULT(debug_name);
+  VmService::SendIsolateStartupMessage(Dart_GetMainPortId(), debug_name);
+
+  Dart_ExitScope();
+  Dart_ExitIsolate();
+
   return isolate;
 }