Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/vmservice/running_isolates.dart

Issue 22607005: Remove race(s) in vmservice tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/main.cc ('K') | « runtime/bin/vmservice/running_isolate.dart ('k') | runtime/bin/vmservice/vmservice.dart » ('j') | runtime/vm/dart_api_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/running_isolates.dart
diff --git a/runtime/bin/vmservice/running_isolates.dart b/runtime/bin/vmservice/running_isolates.dart
index 57e56fb7fe170584c6604165b172471093c954ad..945e4f28efdbc3efc3a8e576c0ba4bfd3b402dd4 100644
--- a/runtime/bin/vmservice/running_isolates.dart
+++ b/runtime/bin/vmservice/running_isolates.dart
@@ -9,13 +9,12 @@ class RunningIsolates implements ServiceRequestRouter {
RunningIsolates();
- void isolateStartup(SendPort sp) {
+ void isolateStartup(SendPort sp, String name) {
if (isolates[sp.hashCode] != null) {
throw new StateError('Duplicate isolate startup.');
}
- var ri = new RunningIsolate(sp);
+ var ri = new RunningIsolate(sp, name);
isolates[sp.hashCode] = ri;
- ri._sendNameRequest();
}
void isolateShutdown(SendPort sp) {
« runtime/bin/main.cc ('K') | « runtime/bin/vmservice/running_isolate.dart ('k') | runtime/bin/vmservice/vmservice.dart » ('j') | runtime/vm/dart_api_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698