Add initial Document::getAnnot support

Add initial Document::getAnnot support

CL implements the first step in order to support
Annotations manipulation in PDFium: Document::getAnnot.

The method takes two arguments, an integer (page number)
and a string (annotation name).
When called, it iterates over the annotations on
the given page number, searching for the one whose name
matches the string in the second parameter.
If found, then an Annot instance (see Annot.cpp/g added by this
CL), is bound to a Javascript object and returned.

With the use cases described in bug [1] as an initial test case,
CL adds support to the following Annotation object properties:

- hidden
- name
- type

Idea is to keep evolving the implementation with more methods
and properties in follow up CLs.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=pdfium:492
Committed: https://pdfium.googlesource.com/pdfium/+/618cb1f3e561b5d2a1dea9ec4653804f0da7267c

[tonikitoo, 2016-08-18 21:10:31]

Description was changed from

==========
Add initial Document::getAnnot support

CL implements the first step in order to support
Annotations manipulation in PDFium: Document::getAnnot.

The method takes two arguments, an integer (page number)
and a string (annotation name).
When called, it iterates over the annotations on
the given page number, searching for the one whose name
matches the string in the second parameter.
If found, the an Annot instance (see Annot.cpp/g added by this
CL), is bound to a Javascript object and returned.

With the use cases described in bug [1] as an initial test case,
CL adds support to the following Annotation object properties:

- hidden
- name
- type

Idea is to keep evolving the implementation with more methods
and properties in follow up CLs.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=pdfium:492
==========

to

==========
Add initial Document::getAnnot support

CL implements the first step in order to support
Annotations manipulation in PDFium: Document::getAnnot.

The method takes two arguments, an integer (page number)
and a string (annotation name).
When called, it iterates over the annotations on
the given page number, searching for the one whose name
matches the string in the second parameter.
If found, the an Annot instance (see Annot.cpp/g added by this
CL), is bound to a Javascript object and returned.

With the use cases described in bug [1] as an initial test case,
CL adds support to the following Annotation object properties:

- hidden
- name
- type

Idea is to keep evolving the implementation with more methods
and properties in follow up CLs.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=pdfium:492
==========

[tonikitoo, 2016-08-18 21:10:31]

tonikitoo@igalia.com changed reviewers:
+ dsinclair@chromium.org, jaepark@google.com, thestig@chromium.org,
tsepez@chromium.org

[tonikitoo, 2016-08-18 21:10:54]

PTAL

[Tom Sepez, 2016-08-18 21:45:06]

Congratulations on navigating the minefield that is CJS_.

LGTM with nits.

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.cpp
File fpdfsdk/javascript/Annot.cpp (right):

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.cp...
fpdfsdk/javascript/Annot.cpp:37: bool bHidden =
CPDF_Annot::IsAnnotationHidden(pPDFAnnot->GetAnnotDict());
nit: Local not needed.

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.h
File fpdfsdk/javascript/Annot.h (right):

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.h#...
fpdfsdk/javascript/Annot.h:22: void SetData(CPDFSDK_BAAnnot* annot);
Nit: maybe call this SetSDKAnnot(), data is kind of a vague name.

[Lei Zhang, 2016-08-19 00:49:06]

Description was changed from

==========
Add initial Document::getAnnot support

CL implements the first step in order to support
Annotations manipulation in PDFium: Document::getAnnot.

The method takes two arguments, an integer (page number)
and a string (annotation name).
When called, it iterates over the annotations on
the given page number, searching for the one whose name
matches the string in the second parameter.
If found, the an Annot instance (see Annot.cpp/g added by this
CL), is bound to a Javascript object and returned.

With the use cases described in bug [1] as an initial test case,
CL adds support to the following Annotation object properties:

- hidden
- name
- type

Idea is to keep evolving the implementation with more methods
and properties in follow up CLs.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=pdfium:492
==========

to

==========
Add initial Document::getAnnot support

CL implements the first step in order to support
Annotations manipulation in PDFium: Document::getAnnot.

The method takes two arguments, an integer (page number)
and a string (annotation name).
When called, it iterates over the annotations on
the given page number, searching for the one whose name
matches the string in the second parameter.
If found, then an Annot instance (see Annot.cpp/g added by this
CL), is bound to a Javascript object and returned.

With the use cases described in bug [1] as an initial test case,
CL adds support to the following Annotation object properties:

- hidden
- name
- type

Idea is to keep evolving the implementation with more methods
and properties in follow up CLs.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=pdfium:492
==========

[Lei Zhang, 2016-08-19 00:56:32]

lgtm

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Document...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:1052: if (!pBAAnnot)
Maybe this block from here down can just be:

    if (pBAAnnot && pBAAnnot->GetAnnotName() == swAnnotName) {
      pSDKBAAnnot = pBAAnnot;
      break;
    }

[tonikitoo, 2016-08-19 02:39:31]

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.cpp
File fpdfsdk/javascript/Annot.cpp (right):

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.cp...
fpdfsdk/javascript/Annot.cpp:37: bool bHidden =
CPDF_Annot::IsAnnotationHidden(pPDFAnnot->GetAnnotDict());
On 2016/08/18 21:45:06, Tom Sepez wrote:
> nit: Local not needed.

Done.

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.h
File fpdfsdk/javascript/Annot.h (right):

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Annot.h#...
fpdfsdk/javascript/Annot.h:22: void SetData(CPDFSDK_BAAnnot* annot);
On 2016/08/18 21:45:06, Tom Sepez wrote:
> Nit: maybe call this SetSDKAnnot(), data is kind of a vague name.

Done.

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Document...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2260663002/diff/1/fpdfsdk/javascript/Document...
fpdfsdk/javascript/Document.cpp:1052: if (!pBAAnnot)
On 2016/08/19 00:56:32, Lei Zhang wrote:
> Maybe this block from here down can just be:
> 
>     if (pBAAnnot && pBAAnnot->GetAnnotName() == swAnnotName) {
>       pSDKBAAnnot = pBAAnnot;
>       break;
>     }

Done.

[tonikitoo, 2016-08-19 02:39:37]

The CQ bit was checked by tonikitoo@igalia.com

[tonikitoo, 2016-08-19 02:39:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2260663002/#ps20001
(title: "Addressed thestig's and tsepez' feedback")

[commit-bot: I haz the power, 2016-08-19 02:39:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 02:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 02:49:35]

Try jobs failed on following builders:
  linux_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel_g...)

[Lei Zhang, 2016-08-19 02:51:31]

https://codereview.chromium.org/2260663002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2260663002/diff/20001/BUILD.gn#newcode873
BUILD.gn:873: "fpdfsdk/javascript/Annot.cpp",
Update the corresponding .gyp file. We'll remove the GYP bots in a week or so.

[tonikitoo, 2016-08-19 02:52:05]

On 2016/08/19 02:49:35, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel_g...)

It seems like we still have GYP bots. Will fix it.

[tonikitoo, 2016-08-19 02:56:07]

The CQ bit was checked by tonikitoo@igalia.com

[tonikitoo, 2016-08-19 02:56:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2260663002/#ps40001
(title: "fix GYP build")

[commit-bot: I haz the power, 2016-08-19 02:56:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 03:10:25]

Description was changed from

==========
Add initial Document::getAnnot support

CL implements the first step in order to support
Annotations manipulation in PDFium: Document::getAnnot.

The method takes two arguments, an integer (page number)
and a string (annotation name).
When called, it iterates over the annotations on
the given page number, searching for the one whose name
matches the string in the second parameter.
If found, then an Annot instance (see Annot.cpp/g added by this
CL), is bound to a Javascript object and returned.

With the use cases described in bug [1] as an initial test case,
CL adds support to the following Annotation object properties:

- hidden
- name
- type

Idea is to keep evolving the implementation with more methods
and properties in follow up CLs.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=pdfium:492
==========

to

==========
Add initial Document::getAnnot support

CL implements the first step in order to support
Annotations manipulation in PDFium: Document::getAnnot.

The method takes two arguments, an integer (page number)
and a string (annotation name).
When called, it iterates over the annotations on
the given page number, searching for the one whose name
matches the string in the second parameter.
If found, then an Annot instance (see Annot.cpp/g added by this
CL), is bound to a Javascript object and returned.

With the use cases described in bug [1] as an initial test case,
CL adds support to the following Annotation object properties:

- hidden
- name
- type

Idea is to keep evolving the implementation with more methods
and properties in follow up CLs.

[1] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=pdfium:492

Committed:
https://pdfium.googlesource.com/pdfium/+/618cb1f3e561b5d2a1dea9ec4653804f0da7...
==========

[commit-bot: I haz the power, 2016-08-19 03:10:26]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/618cb1f3e561b5d2a1dea9ec4653804f0da7...