Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issue 2260573002: predictors: Track whether resources have validators, and require validation. (Closed)

Created:
4 years, 4 months ago by Benoit L
Modified:
4 years, 4 months ago
Reviewers:
pasko
CC:
chromium-reviews, shishir+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Track whether resources have validators, and require validation. This adds to the database whether resources have validators, and are never fresh because they require revalidation each time. This will be used later to adjust the priority. Also adds tests for SummarizeResponse, and unifies (and fixes) the content type handling in it. BUG=631966 Committed: https://crrev.com/c65a3bf951519f90b6be30a1bded64a7001e59d0 Cr-Commit-Position: refs/heads/master@{#413202}

Patch Set 1 #

Patch Set 2 : Typo. #

Total comments: 1

Patch Set 3 : Typo. #

Patch Set 4 : Make Visual Studio happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -174 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 6 chunks +42 lines, -15 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 1 2 3 12 chunks +34 lines, -20 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 5 chunks +68 lines, -51 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 2 12 chunks +175 lines, -82 lines 0 comments Download
M tools/resource_prefetch_predictor/prefetch_predictor_tool.py View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Benoit L
4 years, 4 months ago (2016-08-18 16:35:16 UTC) #4
pasko
lgtm with bots passing https://codereview.chromium.org/2260573002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc File chrome/browser/predictors/resource_prefetch_predictor_unittest.cc (right): https://codereview.chromium.org/2260573002/diff/20001/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc#newcode984 chrome/browser/predictors/resource_prefetch_predictor_unittest.cc:984: response_info.headers = MakeResponseHeaders does it ...
4 years, 4 months ago (2016-08-19 16:17:42 UTC) #7
Benoit L
Thanks! And sorry for the missing "(" :-/
4 years, 4 months ago (2016-08-19 16:34:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260573002/60001
4 years, 4 months ago (2016-08-19 18:59:06 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-19 19:04:06 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 19:08:29 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c65a3bf951519f90b6be30a1bded64a7001e59d0
Cr-Commit-Position: refs/heads/master@{#413202}

Powered by Google App Engine
This is Rietveld 408576698