predictors: Track whether resources have validators, and require validation.

chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
 
 #include <iostream>
 #include <memory>
 
 #include "base/memory/ptr_util.h"
@@ skipping 41 matching lines @@
   *os << "[" << data.key_type << "," << data.primary_key
       << "," << data.last_visit.ToInternalValue() << "]\n";
   for (ResourceRows::const_iterator it = data.resources.begin();
        it != data.resources.end(); ++it) {
     *os << "\t\t";
     PrintTo(*it, os);
     *os << "\n";
   }
 }
 
+scoped_refptr<net::HttpResponseHeaders> MakeResponseHeaders(
+    const char* headers) {
+  return make_scoped_refptr(new net::HttpResponseHeaders(
+      net::HttpUtil::AssembleRawHeaders(headers, strlen(headers))));
+}
+
 class EmptyURLRequestDelegate : public net::URLRequest::Delegate {
   void OnResponseStarted(net::URLRequest* request) override {}
   void OnReadCompleted(net::URLRequest* request, int bytes_read) override {}
 };
 
 class MockURLRequestJob : public net::URLRequestJob {
  public:
   MockURLRequestJob(net::URLRequest* request,
                     const net::HttpResponseInfo& response_info,
                     const std::string& mime_type)
@@ skipping 241 matching lines @@
 
 void ResourcePrefetchPredictorTest::TearDown() {
   predictor_.reset(NULL);
   profile_->DestroyHistoryService();
 }
 
 void ResourcePrefetchPredictorTest::InitializeSampleData() {
   {  // Url data.
     PrefetchData google(PREFETCH_KEY_TYPE_URL, "http://www.google.com/");
     google.last_visit = base::Time::FromInternalValue(1);
+    google.resources.push_back(
+        ResourceRow(std::string(), "http://google.com/style1.css",
+                    content::RESOURCE_TYPE_STYLESHEET, 3, 2, 1, 1.0,
+                    net::MEDIUM, false, false));
+    google.resources.push_back(ResourceRow(std::string(),
+                                           "http://google.com/script3.js",
+                                           content::RESOURCE_TYPE_SCRIPT, 4, 0,
+                                           1, 2.1, net::MEDIUM, false, false));
+    google.resources.push_back(ResourceRow(std::string(),
+                                           "http://google.com/script4.js",
+                                           content::RESOURCE_TYPE_SCRIPT, 11, 0,
+                                           0, 2.1, net::MEDIUM, false, false));
     google.resources.push_back(ResourceRow(
-        std::string(), "http://google.com/style1.css",
-        content::RESOURCE_TYPE_STYLESHEET, 3, 2, 1, 1.0, net::MEDIUM));
+        std::string(), "http://google.com/image1.png",
+        content::RESOURCE_TYPE_IMAGE, 6, 3, 0, 2.2, net::MEDIUM, false, false));
     google.resources.push_back(
-        ResourceRow(std::string(), "http://google.com/script3.js",
-                    content::RESOURCE_TYPE_SCRIPT, 4, 0, 1, 2.1, net::MEDIUM));
-    google.resources.push_back(
-        ResourceRow(std::string(), "http://google.com/script4.js",
-                    content::RESOURCE_TYPE_SCRIPT, 11, 0, 0, 2.1, net::MEDIUM));
-    google.resources.push_back(
-        ResourceRow(std::string(), "http://google.com/image1.png",
-                    content::RESOURCE_TYPE_IMAGE, 6, 3, 0, 2.2, net::MEDIUM));
-    google.resources.push_back(ResourceRow(
-        std::string(), "http://google.com/a.font",
-        content::RESOURCE_TYPE_LAST_TYPE, 2, 0, 0, 5.1, net::MEDIUM));
+        ResourceRow(std::string(), "http://google.com/a.font",
+                    content::RESOURCE_TYPE_LAST_TYPE, 2, 0, 0, 5.1, net::MEDIUM,
+                    false, false));
 
     PrefetchData reddit(PREFETCH_KEY_TYPE_URL, "http://www.reddit.com/");
     reddit.last_visit = base::Time::FromInternalValue(2);
     reddit.resources.push_back(
         ResourceRow(std::string(), "http://reddit-resource.com/script1.js",
-                    content::RESOURCE_TYPE_SCRIPT, 4, 0, 1, 1.0, net::MEDIUM));
+                    content::RESOURCE_TYPE_SCRIPT, 4, 0, 1, 1.0, net::MEDIUM,
+                    false, false));
     reddit.resources.push_back(
         ResourceRow(std::string(), "http://reddit-resource.com/script2.js",
-                    content::RESOURCE_TYPE_SCRIPT, 2, 0, 0, 2.1, net::MEDIUM));
+                    content::RESOURCE_TYPE_SCRIPT, 2, 0, 0, 2.1, net::MEDIUM,
+                    false, false));
 
     PrefetchData yahoo(PREFETCH_KEY_TYPE_URL, "http://www.yahoo.com/");
     yahoo.last_visit = base::Time::FromInternalValue(3);
-    yahoo.resources.push_back(
-        ResourceRow(std::string(), "http://google.com/image.png",
-                    content::RESOURCE_TYPE_IMAGE, 20, 1, 0, 10.0, net::MEDIUM));
+    yahoo.resources.push_back(ResourceRow(std::string(),
+                                          "http://google.com/image.png",
+                                          content::RESOURCE_TYPE_IMAGE, 20, 1,
+                                          0, 10.0, net::MEDIUM, false, false));
 
     test_url_data_.clear();
     test_url_data_.insert(std::make_pair("http://www.google.com/", google));
     test_url_data_.insert(std::make_pair("http://www.reddit.com/", reddit));
     test_url_data_.insert(std::make_pair("http://www.yahoo.com/", yahoo));
   }
 
   {  // Host data.
     PrefetchData facebook(PREFETCH_KEY_TYPE_HOST, "www.facebook.com");
     facebook.last_visit = base::Time::FromInternalValue(4);
-    facebook.resources.push_back(ResourceRow(
-        std::string(), "http://www.facebook.com/style.css",
-        content::RESOURCE_TYPE_STYLESHEET, 5, 2, 1, 1.1, net::MEDIUM));
+    facebook.resources.push_back(
+        ResourceRow(std::string(), "http://www.facebook.com/style.css",
+                    content::RESOURCE_TYPE_STYLESHEET, 5, 2, 1, 1.1,
+                    net::MEDIUM, false, false));
     facebook.resources.push_back(
         ResourceRow(std::string(), "http://www.facebook.com/script.js",
-                    content::RESOURCE_TYPE_SCRIPT, 4, 0, 1, 2.1, net::MEDIUM));
+                    content::RESOURCE_TYPE_SCRIPT, 4, 0, 1, 2.1, net::MEDIUM,
+                    false, false));
+    facebook.resources.push_back(ResourceRow(
+        std::string(), "http://www.facebook.com/image.png",
+        content::RESOURCE_TYPE_IMAGE, 6, 3, 0, 2.2, net::MEDIUM, false, false));
     facebook.resources.push_back(
-        ResourceRow(std::string(), "http://www.facebook.com/image.png",
-                    content::RESOURCE_TYPE_IMAGE, 6, 3, 0, 2.2, net::MEDIUM));
-    facebook.resources.push_back(ResourceRow(
-        std::string(), "http://www.facebook.com/a.font",
-        content::RESOURCE_TYPE_LAST_TYPE, 2, 0, 0, 5.1, net::MEDIUM));
+        ResourceRow(std::string(), "http://www.facebook.com/a.font",
+                    content::RESOURCE_TYPE_LAST_TYPE, 2, 0, 0, 5.1, net::MEDIUM,
+                    false, false));
     facebook.resources.push_back(ResourceRow(
         std::string(), "http://www.resources.facebook.com/script.js",
-        content::RESOURCE_TYPE_SCRIPT, 11, 0, 0, 8.5, net::MEDIUM));
+        content::RESOURCE_TYPE_SCRIPT, 11, 0, 0, 8.5, net::MEDIUM, false,
+        false));
 
     PrefetchData yahoo(PREFETCH_KEY_TYPE_HOST, "www.yahoo.com");
     yahoo.last_visit = base::Time::FromInternalValue(5);
-    yahoo.resources.push_back(
-        ResourceRow(std::string(), "http://google.com/image.png",
-                    content::RESOURCE_TYPE_IMAGE, 20, 1, 0, 10.0, net::MEDIUM));
+    yahoo.resources.push_back(ResourceRow(std::string(),
+                                          "http://google.com/image.png",
+                                          content::RESOURCE_TYPE_IMAGE, 20, 1,
+                                          0, 10.0, net::MEDIUM, false, false));
 
     test_host_data_.clear();
     test_host_data_.insert(std::make_pair("www.facebook.com", facebook));
     test_host_data_.insert(std::make_pair("www.yahoo.com", yahoo));
   }
 }
 
 TEST_F(ResourcePrefetchPredictorTest, LazilyInitializeEmpty) {
   // Tests that the predictor initializes correctly without any data.
   EXPECT_TRUE(predictor_->url_table_cache_->empty());
@@ skipping 41 matching lines @@
   URLRequestSummary resource2 = CreateURLRequestSummary(
       1, 1, "http://www.google.com", "http://google.com/script1.js",
       content::RESOURCE_TYPE_SCRIPT, net::MEDIUM, "text/javascript", false);
   predictor_->RecordURLResponse(resource2);
   URLRequestSummary resource3 = CreateURLRequestSummary(
       1, 1, "http://www.google.com", "http://google.com/script2.js",
       content::RESOURCE_TYPE_SCRIPT, net::MEDIUM, "text/javascript", false);
   predictor_->RecordURLResponse(resource3);
 
   PrefetchData host_data(PREFETCH_KEY_TYPE_HOST, "www.google.com");
+  host_data.resources.push_back(
+      ResourceRow(std::string(), "http://google.com/style1.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM,
+                  false, false));
   host_data.resources.push_back(ResourceRow(
-      std::string(), "http://google.com/style1.css",
-      content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM));
-  host_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script1.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM));
-  host_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script2.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM));
+      std::string(), "http://google.com/script1.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM, false, false));
+  host_data.resources.push_back(ResourceRow(
+      std::string(), "http://google.com/script2.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM, false, false));
   EXPECT_CALL(*mock_tables_.get(), UpdateData(empty_url_data_, host_data));
 
   predictor_->OnNavigationComplete(main_frame.navigation_id);
   profile_->BlockUntilHistoryProcessesPendingRequests();
 }
 
 TEST_F(ResourcePrefetchPredictorTest, NavigationUrlNotInDB) {
   // Single navigation that will be recorded. Will check for duplicate
   // resources and also for number of resources saved.
   AddUrlToHistory("http://www.google.com", 4);
@@ skipping 27 matching lines @@
   URLRequestSummary resource6 = CreateURLRequestSummary(
       1, 1, "http://www.google.com", "http://google.com/image2.png",
       content::RESOURCE_TYPE_IMAGE, net::MEDIUM, "image/png", false);
   predictor_->RecordURLResponse(resource6);
   URLRequestSummary resource7 = CreateURLRequestSummary(
       1, 1, "http://www.google.com", "http://google.com/style2.css",
       content::RESOURCE_TYPE_STYLESHEET, net::MEDIUM, "text/css", true);
   predictor_->RecordURLResponse(resource7);
 
   PrefetchData url_data(PREFETCH_KEY_TYPE_URL, "http://www.google.com/");
+  url_data.resources.push_back(
+      ResourceRow(std::string(), "http://google.com/style1.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM,
+                  false, false));
   url_data.resources.push_back(ResourceRow(
-      std::string(), "http://google.com/style1.css",
-      content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM));
+      std::string(), "http://google.com/script1.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM, false, false));
+  url_data.resources.push_back(ResourceRow(
+      std::string(), "http://google.com/script2.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM, false, false));
   url_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script1.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM));
-  url_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script2.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM));
-  url_data.resources.push_back(ResourceRow(
-      std::string(), "http://google.com/style2.css",
-      content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 7.0, net::MEDIUM));
+      ResourceRow(std::string(), "http://google.com/style2.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 7.0, net::MEDIUM,
+                  false, false));
   EXPECT_CALL(*mock_tables_.get(), UpdateData(url_data, empty_host_data_));
 
   PrefetchData host_data(PREFETCH_KEY_TYPE_HOST, "www.google.com");
   host_data.resources = url_data.resources;
   EXPECT_CALL(*mock_tables_.get(), UpdateData(empty_url_data_, host_data));
 
   predictor_->OnNavigationComplete(main_frame.navigation_id);
   profile_->BlockUntilHistoryProcessesPendingRequests();
 }
 
@@ skipping 41 matching lines @@
   URLRequestSummary resource6 = CreateURLRequestSummary(
       1, 1, "http://www.google.com", "http://google.com/image2.png",
       content::RESOURCE_TYPE_IMAGE, net::MEDIUM, "image/png", false);
   predictor_->RecordURLResponse(resource6);
   URLRequestSummary resource7 = CreateURLRequestSummary(
       1, 1, "http://www.google.com", "http://google.com/style2.css",
       content::RESOURCE_TYPE_STYLESHEET, net::MEDIUM, "text/css", true);
   predictor_->RecordURLResponse(resource7);
 
   PrefetchData url_data(PREFETCH_KEY_TYPE_URL, "http://www.google.com/");
+  url_data.resources.push_back(
+      ResourceRow(std::string(), "http://google.com/style1.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 4, 2, 0, 1.0, net::MEDIUM,
+                  false, false));
   url_data.resources.push_back(ResourceRow(
-      std::string(), "http://google.com/style1.css",
-      content::RESOURCE_TYPE_STYLESHEET, 4, 2, 0, 1.0, net::MEDIUM));
-  url_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script1.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM));
-  url_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script4.js",
-                  content::RESOURCE_TYPE_SCRIPT, 11, 1, 1, 2.1, net::MEDIUM));
-  url_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script2.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM));
+      std::string(), "http://google.com/script1.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM, false, false));
+  url_data.resources.push_back(ResourceRow(
+      std::string(), "http://google.com/script4.js",
+      content::RESOURCE_TYPE_SCRIPT, 11, 1, 1, 2.1, net::MEDIUM, false, false));
+  url_data.resources.push_back(ResourceRow(
+      std::string(), "http://google.com/script2.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM, false, false));
   EXPECT_CALL(*mock_tables_.get(), UpdateData(url_data, empty_host_data_));
 
   EXPECT_CALL(
       *mock_tables_.get(),
       DeleteSingleDataPoint("www.facebook.com", PREFETCH_KEY_TYPE_HOST));
 
   PrefetchData host_data(PREFETCH_KEY_TYPE_HOST, "www.google.com");
+  host_data.resources.push_back(
+      ResourceRow(std::string(), "http://google.com/style1.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM,
+                  false, false));
   host_data.resources.push_back(ResourceRow(
-      std::string(), "http://google.com/style1.css",
-      content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM));
+      std::string(), "http://google.com/script1.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM, false, false));
+  host_data.resources.push_back(ResourceRow(
+      std::string(), "http://google.com/script2.js",
+      content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM, false, false));
   host_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script1.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 2.0, net::MEDIUM));
-  host_data.resources.push_back(
-      ResourceRow(std::string(), "http://google.com/script2.js",
-                  content::RESOURCE_TYPE_SCRIPT, 1, 0, 0, 3.0, net::MEDIUM));
-  host_data.resources.push_back(ResourceRow(
-      std::string(), "http://google.com/style2.css",
-      content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 7.0, net::MEDIUM));
+      ResourceRow(std::string(), "http://google.com/style2.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 7.0, net::MEDIUM,
+                  false, false));
   EXPECT_CALL(*mock_tables_.get(), UpdateData(empty_url_data_, host_data));
 
   predictor_->OnNavigationComplete(main_frame.navigation_id);
   profile_->BlockUntilHistoryProcessesPendingRequests();
 }
 
 TEST_F(ResourcePrefetchPredictorTest, NavigationUrlNotInDBAndDBFull) {
   // Tests that a URL is deleted before another is added if the cache is full.
   AddUrlToHistory("http://www.nike.com/", 4);
 
@@ skipping 23 matching lines @@
   predictor_->RecordURLResponse(resource2);
 
   EXPECT_CALL(
       *mock_tables_.get(),
       DeleteSingleDataPoint("http://www.google.com/", PREFETCH_KEY_TYPE_URL));
   EXPECT_CALL(
       *mock_tables_.get(),
       DeleteSingleDataPoint("www.facebook.com", PREFETCH_KEY_TYPE_HOST));
 
   PrefetchData url_data(PREFETCH_KEY_TYPE_URL, "http://www.nike.com/");
+  url_data.resources.push_back(
+      ResourceRow(std::string(), "http://nike.com/style1.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM,
+                  false, false));
   url_data.resources.push_back(ResourceRow(
-      std::string(), "http://nike.com/style1.css",
-      content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM));
-  url_data.resources.push_back(
-      ResourceRow(std::string(), "http://nike.com/image2.png",
-                  content::RESOURCE_TYPE_IMAGE, 1, 0, 0, 2.0, net::MEDIUM));
+      std::string(), "http://nike.com/image2.png", content::RESOURCE_TYPE_IMAGE,
+      1, 0, 0, 2.0, net::MEDIUM, false, false));
   EXPECT_CALL(*mock_tables_.get(), UpdateData(url_data, empty_host_data_));
 
   PrefetchData host_data(PREFETCH_KEY_TYPE_HOST, "www.nike.com");
   host_data.resources = url_data.resources;
   EXPECT_CALL(*mock_tables_.get(), UpdateData(empty_url_data_, host_data));
 
   predictor_->OnNavigationComplete(main_frame.navigation_id);
   profile_->BlockUntilHistoryProcessesPendingRequests();
 }
 
@@ skipping 183 matching lines @@
   main_frame.navigation_id.creation_time = base::TimeTicks();
   EXPECT_TRUE(main_frame.navigation_id.creation_time.is_null());
 
   // Now add a subresource.
   URLRequestSummary resource1 = CreateURLRequestSummary(
       1, 1, "http://www.google.com", "http://google.com/style1.css",
       content::RESOURCE_TYPE_STYLESHEET, net::MEDIUM, "text/css", false);
   predictor_->RecordURLResponse(resource1);
 
   PrefetchData host_data(PREFETCH_KEY_TYPE_HOST, "www.google.com");
-  host_data.resources.push_back(ResourceRow(
-      std::string(), "http://google.com/style1.css",
-      content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM));
+  host_data.resources.push_back(
+      ResourceRow(std::string(), "http://google.com/style1.css",
+                  content::RESOURCE_TYPE_STYLESHEET, 1, 0, 0, 1.0, net::MEDIUM,
+                  false, false));
   EXPECT_CALL(*mock_tables_.get(), UpdateData(empty_url_data_, host_data));
 
   // The page load time will be collected by RPP_HISTOGRAM_MEDIUM_TIMES, which
   // has a upper bound of 3 minutes.
   base::TimeDelta plt =
       predictor_->OnNavigationComplete(main_frame.navigation_id);
   EXPECT_LT(plt, base::TimeDelta::FromSeconds(180));
 
   profile_->BlockUntilHistoryProcessesPendingRequests();
 }
@@ skipping 54 matching lines @@
 
   std::unique_ptr<net::URLRequest> file_request =
       CreateURLRequest(GURL("file://www.google.com/cat.png"), net::MEDIUM,
                        content::RESOURCE_TYPE_IMAGE, 1, 1, false);
   EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordRequest(
       file_request.get(), content::RESOURCE_TYPE_IMAGE));
 }
 
 TEST_F(ResourcePrefetchPredictorTest, ShouldRecordResponseMainFrame) {
   net::HttpResponseInfo response_info;
-  response_info.headers =
-      scoped_refptr<net::HttpResponseHeaders>(new net::HttpResponseHeaders(""));
+  response_info.headers = MakeResponseHeaders("");
   url_request_job_factory_.set_response_info(response_info);
 
   std::unique_ptr<net::URLRequest> http_request =
       CreateURLRequest(GURL("http://www.google.com"), net::MEDIUM,
                        content::RESOURCE_TYPE_MAIN_FRAME, 1, 1, true);
   EXPECT_TRUE(
       ResourcePrefetchPredictor::ShouldRecordResponse(http_request.get()));
 
   std::unique_ptr<net::URLRequest> https_request =
       CreateURLRequest(GURL("https://www.google.com"), net::MEDIUM,
                        content::RESOURCE_TYPE_MAIN_FRAME, 1, 1, true);
   EXPECT_TRUE(
       ResourcePrefetchPredictor::ShouldRecordResponse(https_request.get()));
 
   std::unique_ptr<net::URLRequest> file_request =
       CreateURLRequest(GURL("file://www.google.com"), net::MEDIUM,
                        content::RESOURCE_TYPE_MAIN_FRAME, 1, 1, true);
   EXPECT_FALSE(
       ResourcePrefetchPredictor::ShouldRecordResponse(file_request.get()));
 }
 
 TEST_F(ResourcePrefetchPredictorTest, ShouldRecordResponseSubresource) {
   net::HttpResponseInfo response_info;
-  response_info.headers = scoped_refptr<net::HttpResponseHeaders>(
-      new net::HttpResponseHeaders("HTTP/1.1 200 OK\n\nSome: Headers\n"));
+  response_info.headers = MakeResponseHeaders

[pasko, 2016/08/19 16:17:42]

does it compile without opening paren?

+      "HTTP/1.1 200 OK\n\nSome: Headers\n");
   response_info.was_cached = true;
   url_request_job_factory_.set_response_info(response_info);
 
   // Protocol
   std::unique_ptr<net::URLRequest> http_image_request =
       CreateURLRequest(GURL("http://www.google.com/cat.png"), net::MEDIUM,
                        content::RESOURCE_TYPE_IMAGE, 1, 1, true);
   EXPECT_TRUE(ResourcePrefetchPredictor::ShouldRecordResponse(
       http_image_request.get()));
 
@@ skipping 53 matching lines @@
       prefetch_unknown_font_request.get()));
 
   // Not main frame
   std::unique_ptr<net::URLRequest> font_request_sub_frame = CreateURLRequest(
       GURL("http://www.google.com/comic-sans-ms.woff"), net::MEDIUM,
       content::RESOURCE_TYPE_FONT_RESOURCE, 1, 1, false);
   EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordResponse(
       font_request_sub_frame.get()));
 }
 
+TEST_F(ResourcePrefetchPredictorTest, SummarizeResponse) {
+  net::HttpResponseInfo response_info;
+  response_info.headers =
+      MakeResponseHeaders("HTTP/1.1 200 OK\n\nSome: Headers\n");
+  response_info.was_cached = true;
+  url_request_job_factory_.set_response_info(response_info);
+
+  GURL url("http://www.google.com/cat.png");
+  std::unique_ptr<net::URLRequest> request = CreateURLRequest(
+      url, net::MEDIUM, content::RESOURCE_TYPE_IMAGE, 1, 1, true);
+  URLRequestSummary summary;
+  EXPECT_TRUE(URLRequestSummary::SummarizeResponse(*request, &summary));
+  EXPECT_EQ(1, summary.navigation_id.render_process_id);
+  EXPECT_EQ(1, summary.navigation_id.render_frame_id);
+  EXPECT_EQ(url, summary.navigation_id.main_frame_url);
+  EXPECT_EQ(url, summary.resource_url);
+  EXPECT_EQ(content::RESOURCE_TYPE_IMAGE, summary.resource_type);
+  EXPECT_TRUE(summary.was_cached);
+  EXPECT_FALSE(summary.has_validators);
+  EXPECT_FALSE(summary.always_revalidate);
+}
+
+TEST_F(ResourcePrefetchPredictorTest, SummarizeResponseContentType) {
+  net::HttpResponseInfo response_info;
+  response_info.headers = MakeResponseHeaders(
+      "HTTP/1.1 200 OK\n\n"
+      "Some: Headers\n"
+      "Content-Type: image/whatever\n");
+  url_request_job_factory_.set_response_info(response_info);
+  url_request_job_factory_.set_mime_type("image/png");
+
+  std::unique_ptr<net::URLRequest> request =
+      CreateURLRequest(GURL("http://www.google.com/cat.png"), net::MEDIUM,
+                       content::RESOURCE_TYPE_PREFETCH, 1, 1, true);
+  URLRequestSummary summary;
+  EXPECT_TRUE(URLRequestSummary::SummarizeResponse(*request, &summary));
+  EXPECT_EQ(content::RESOURCE_TYPE_IMAGE, summary.resource_type);
+}
+
+TEST_F(ResourcePrefetchPredictorTest, SummarizeResponseCachePolicy) {
+  net::HttpResponseInfo response_info;
+  response_info.headers = MakeResponseHeaders(
+      "HTTP/1.1 200 OK\n"
+      "Some: Headers\n");
+  url_request_job_factory_.set_response_info(response_info);
+
+  std::unique_ptr<net::URLRequest> request_no_validators =
+      CreateURLRequest(GURL("http://www.google.com/cat.png"), net::MEDIUM,
+                       content::RESOURCE_TYPE_PREFETCH, 1, 1, true);
+
+  URLRequestSummary summary;
+  EXPECT_TRUE(
+      URLRequestSummary::SummarizeResponse(*request_no_validators, &summary));
+  EXPECT_FALSE(summary.has_validators);
+
+  response_info.headers = MakeResponseHeaders(
+      "HTTP/1.1 200 OK\n"
+      "ETag: \"Cr66\"\n"
+      "Cache-Control: no-cache\n");
+  url_request_job_factory_.set_response_info(response_info);
+  std::unique_ptr<net::URLRequest> request_etag =
+      CreateURLRequest(GURL("http://www.google.com/cat.png"), net::MEDIUM,
+                       content::RESOURCE_TYPE_PREFETCH, 1, 1, true);
+  EXPECT_TRUE(URLRequestSummary::SummarizeResponse(*request_etag, &summary));
+  EXPECT_TRUE(summary.has_validators);
+  EXPECT_TRUE(summary.always_revalidate);
+}
+
 }  // namespace predictors