Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: git_cl.py

Issue 2260453002: git cl: avoid infinite recursion during debug/development. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 9fabcc38beb35f4302f9f1be32569890189a4e94..42af2a77f2bc6d09e8b9b2e02255e88e6644e9fd 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1461,7 +1461,12 @@ class Changelist(object):
# This is because lots of untested code accesses Rietveld-specific stuff
# directly, and it's hard to fix for sure. So, just let it work, and fix
# on a case by case basis.
- return getattr(self._codereview_impl, attr)
+ # Note that child method defines __getattr__ as well, and forwards it here,
+ # because _RietveldChangelistImpl is not cleaned up yet, and given
+ # deprecation of Rietveld, it should probably be just removed.
+ # Until that time, avoid infinite recursion by bypassing __getattr__
+ # of implementation class.
+ return self._codereview_impl.__getattribute__(attr)
class _ChangelistCodereviewBase(object):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698