git cl: avoid infinite recursion during debug/development.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from __future__ import print_function
@@ skipping 1443 matching lines @@
   def GetApprovingReviewers(self):
     return self._codereview_impl.GetApprovingReviewers()
 
   def GetMostRecentPatchset(self):
     return self._codereview_impl.GetMostRecentPatchset()
 
   def __getattr__(self, attr):
     # This is because lots of untested code accesses Rietveld-specific stuff
     # directly, and it's hard to fix for sure. So, just let it work, and fix
     # on a case by case basis.
-    return getattr(self._codereview_impl, attr)
+    # Note that child method defines __getattr__ as well, and forwards it here,
+    # because _RietveldChangelistImpl is not cleaned up yet, and given
+    # deprecation of Rietveld, it should probably be just removed.
+    # Until that time, avoid infinite recursion by bypassing __getattr__
+    # of implementation class.
+    return self._codereview_impl.__getattribute__(attr)
 
 
 class _ChangelistCodereviewBase(object):
   """Abstract base class encapsulating codereview specifics of a changelist."""
   def __init__(self, changelist):
     self._changelist = changelist  # instance of Changelist
 
   def __getattr__(self, attr):
     # Forward methods to changelist.
     # TODO(tandrii): maybe clean up _GerritChangelistImpl and
@@ skipping 3673 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)