chrome/browser/extensions/api/webview/webview_api.h - Issue 226043005: Fix webview.executeScript API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webview/webview_api.h

Issue 226043005: Fix webview.executeScript API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add check for invalid url. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/webview/webview_api.h

diff --git a/chrome/browser/extensions/api/webview/webview_api.h b/chrome/browser/extensions/api/webview/webview_api.h

index 00bb2fed98ea86a447d052b1c409976ff7f00343..33453af83b78176ef8f649c21363bb161723dace 100644

--- a/chrome/browser/extensions/api/webview/webview_api.h

+++ b/chrome/browser/extensions/api/webview/webview_api.h

@@ -138,6 +138,7 @@ class WebviewExecuteCodeFunction : public extensions::ExecuteCodeFunction {

// Guarded by a process ID check.

virtual extensions::ScriptExecutor* GetScriptExecutor() OVERRIDE FINAL;

virtual bool IsWebView() const OVERRIDE;

+ virtual GURL GetWebViewSrc() const OVERRIDE;

private:

// Contains extension resource built from path of file which is

@@ -146,6 +147,8 @@ class WebviewExecuteCodeFunction : public extensions::ExecuteCodeFunction {

int guest_instance_id_;

+ GURL guest_src_;

DISALLOW_COPY_AND_ASSIGN(WebviewExecuteCodeFunction);

};