Fix webview.executeScript API

chrome/browser/extensions/api/webview/webview_api.cc

Index: chrome/browser/extensions/api/webview/webview_api.cc
diff --git a/chrome/browser/extensions/api/webview/webview_api.cc b/chrome/browser/extensions/api/webview/webview_api.cc
index 7879c3be8040a3997c9c7c2f4a52485e388e5f7f..bcb7382b6b57bf7fbf26a3342baa47f4bb915604 100644
--- a/chrome/browser/extensions/api/webview/webview_api.cc
+++ b/chrome/browser/extensions/api/webview/webview_api.cc
@@ -263,8 +263,17 @@ bool WebviewExecuteCodeFunction::Init() {
   if (!guest_instance_id_)
     return false;
 
+  std::string src;
+  if (!args_->GetString(1, &src))
+    return false;
+
+  guest_src_ = GURL(src);
+
+  if (!guest_src_.is_valid())
+    return false;
+
   base::DictionaryValue* details_value = NULL;
-  if (!args_->GetDictionary(1, &details_value))
+  if (!args_->GetDictionary(2, &details_value))
     return false;
   scoped_ptr<InjectDetails> details(new InjectDetails());
   if (!InjectDetails::Populate(*details_value, details.get()))
@@ -295,6 +304,8 @@ bool WebviewExecuteCodeFunction::IsWebView() const {
   return true;
 }
 
+GURL WebviewExecuteCodeFunction::GetWebViewSrc() const { return guest_src_; }

[Fady Samuel, 2014/04/07 21:10:45]

You can probably return const GURL&

[Xi Han, 2014/04/07 21:42:15]

Done.

+
 WebviewExecuteScriptFunction::WebviewExecuteScriptFunction() {
 }