chrome/browser/extensions/script_executor.h - Issue 226043005: Fix webview.executeScript API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/script_executor.h

Issue 226043005: Fix webview.executeScript API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small changes are made. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/script_executor.h

diff --git a/chrome/browser/extensions/script_executor.h b/chrome/browser/extensions/script_executor.h

index 03c1f550c30a5161c56c33a54740f6c3dbd193fb..624f608eb2ad64460b9582a3e6f624b2ee0f54ee 100644

--- a/chrome/browser/extensions/script_executor.h

+++ b/chrome/browser/extensions/script_executor.h

@@ -86,6 +86,7 @@ class ScriptExecutor {

UserScript::RunLocation run_at,

WorldType world_type,

ProcessType process_type,

+ const std::string webview_src,

not at google - send to devlin 2014/04/07 17:43:00 should be a const&. but make it a GURL not a stri

Xi Han 2014/04/07 21:03:37 Done.

const GURL& file_url,

bool user_gesture,

ResultType result_type,