Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: chrome/browser/extensions/api/webview/webview_api.cc

Issue 226043005: Fix webview.executeScript API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small changes are made. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webview/webview_api.cc
diff --git a/chrome/browser/extensions/api/webview/webview_api.cc b/chrome/browser/extensions/api/webview/webview_api.cc
index 7879c3be8040a3997c9c7c2f4a52485e388e5f7f..345f28d1d560c5d0b2d47be2429fbade6ee1a2a7 100644
--- a/chrome/browser/extensions/api/webview/webview_api.cc
+++ b/chrome/browser/extensions/api/webview/webview_api.cc
@@ -263,8 +263,15 @@ bool WebviewExecuteCodeFunction::Init() {
if (!guest_instance_id_)
return false;
+ if (!args_->GetString(1, &guest_src_))
+ return false;
+
+ if (guest_src_.empty()) {
+ return false;
+ }
not at google - send to devlin 2014/04/07 17:43:00 make braces consistent i.e. here leave them out.
Xi Han 2014/04/07 21:03:37 Done.
+
base::DictionaryValue* details_value = NULL;
- if (!args_->GetDictionary(1, &details_value))
+ if (!args_->GetDictionary(2, &details_value))
return false;
scoped_ptr<InjectDetails> details(new InjectDetails());
if (!InjectDetails::Populate(*details_value, details.get()))
@@ -295,6 +302,10 @@ bool WebviewExecuteCodeFunction::IsWebView() const {
return true;
}
+std::string WebviewExecuteCodeFunction::GetWebViewSrc() const {
+ return guest_src_;
+}
+
WebviewExecuteScriptFunction::WebviewExecuteScriptFunction() {
}

Powered by Google App Engine
This is Rietveld 408576698