Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/nacl/common/nacl_switches.cc

Issue 226033002: Ensure seccomp-bpf cannot be silently disabled for non-SFI NaCl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/nacl/common/nacl_switches.h ('K') | « components/nacl/common/nacl_switches.h ('k') | components/nacl/loader/nacl_helper_linux.cc » ('j') | components/nacl/loader/nacl_helper_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/common/nacl_switches.cc
diff --git a/components/nacl/common/nacl_switches.cc b/components/nacl/common/nacl_switches.cc
index 732f0e709fb71c4fb03bd17286fa52e948283887..dc1376cd91ee8a1e3d85b02460c942bb1940cbd6 100644
--- a/components/nacl/common/nacl_switches.cc
+++ b/components/nacl/common/nacl_switches.cc
@@ -47,4 +47,9 @@ const char kNaClLoaderProcess[] = "nacl-loader";
// for non SFI mode.
const char kNaClLoaderNonSfiProcess[] = "nacl-loader-nonsfi";
+// Disable sandbox even for non SFI mode. This is particularly unsafe
+// as non SFI NaCl heavily relies on the seccomp sandbox.
+const char kNaClDangerousNoSandboxNonSfi[] =
Mark Seaborn 2014/04/07 23:39:48 Nit: please sort these
hamaji 2014/04/08 04:38:30 Done.
+ "nacl-dangerous-no-sandbox-nonsfi";
+
} // namespace switches
« components/nacl/common/nacl_switches.h ('K') | « components/nacl/common/nacl_switches.h ('k') | components/nacl/loader/nacl_helper_linux.cc » ('j') | components/nacl/loader/nacl_helper_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698