components/nacl/common/nacl_switches.cc - Issue 226033002: Ensure seccomp-bpf cannot be silently disabled for non-SFI NaCl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/common/nacl_switches.cc

Issue 226033002: Ensure seccomp-bpf cannot be silently disabled for non-SFI NaCl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/nacl/common/nacl_switches.h ('K') | « components/nacl/common/nacl_switches.h ('k') | components/nacl/loader/nacl_helper_linux.cc » ('j') | components/nacl/loader/nacl_helper_linux.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/nacl/common/nacl_switches.h"	5 #include "components/nacl/common/nacl_switches.h"

6	6

7 namespace switches {	7 namespace switches {

8	8

9 // Disables crash throttling for Portable Native Client.	9 // Disables crash throttling for Portable Native Client.

10 const char kDisablePnaclCrashThrottling[] = "disable-pnacl-crash-throttling";	10 const char kDisablePnaclCrashThrottling[] = "disable-pnacl-crash-throttling";

(...skipping 29 matching lines...) Expand all Loading...
40 const char kNaClGdbScript[] = "nacl-gdb-script";	40 const char kNaClGdbScript[] = "nacl-gdb-script";

41	41

42 // Value for --type that causes the process to run as a NativeClient loader	42 // Value for --type that causes the process to run as a NativeClient loader

43 // for SFI mode.	43 // for SFI mode.

44 const char kNaClLoaderProcess[] = "nacl-loader";	44 const char kNaClLoaderProcess[] = "nacl-loader";

45	45

46 // Value for --type that causes the process to run as a NativeClient loader	46 // Value for --type that causes the process to run as a NativeClient loader

47 // for non SFI mode.	47 // for non SFI mode.

48 const char kNaClLoaderNonSfiProcess[] = "nacl-loader-nonsfi";	48 const char kNaClLoaderNonSfiProcess[] = "nacl-loader-nonsfi";

49	49

	50 // Disable sandbox even for non SFI mode. This is particularly unsafe

	51 // as non SFI NaCl heavily relies on the seccomp sandbox.

	52 const char kNaClDangerousNoSandboxNonSfi[] =
	Mark Seaborn 2014/04/07 23:39:48 Nit: please sort these Nit: please sort these hamaji 2014/04/08 04:38:30 Done. Show quoted text On 2014/04/07 23:39:48, Mark Seaborn wrote: > Nit: please sort these Done.
	53 "nacl-dangerous-no-sandbox-nonsfi";

	54

50 } // namespace switches	55 } // namespace switches

OLD	NEW