Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2260283002: Adapt WebRange to only deal with EphemeralRanges. (Closed)

Created:
4 years, 4 months ago by dglazkov
Modified:
4 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adapt WebRange to only deal with EphemeralRanges. Range instantiation is expensive, and is not necessary for all of the uses of the WebRange. So let's use EphemeralRanges instead. BUG=636216 R=esprehn Committed: https://crrev.com/a3d9b2366eedee516376706c9eb7cb1c54ffaa16 Cr-Commit-Position: refs/heads/master@{#413360}

Patch Set 1 #

Patch Set 2 : Added back the isNull case, sorry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 4 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/WebRange.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebRange.h View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dglazkov
Added back the isNull case, sorry.
4 years, 4 months ago (2016-08-19 21:32:21 UTC) #5
dglazkov
PTAL.
4 years, 4 months ago (2016-08-19 21:56:27 UTC) #8
esprehn
lgtm
4 years, 4 months ago (2016-08-19 22:21:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260283002/20001
4 years, 4 months ago (2016-08-21 00:00:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-21 01:43:22 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 01:45:18 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3d9b2366eedee516376706c9eb7cb1c54ffaa16
Cr-Commit-Position: refs/heads/master@{#413360}

Powered by Google App Engine
This is Rietveld 408576698