Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: third_party/WebKit/public/web/WebRange.h

Issue 2260283002: Adapt WebRange to only deal with EphemeralRanges. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added back the isNull case, sorry. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebRange.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef WebRange_h 31 #ifndef WebRange_h
32 #define WebRange_h 32 #define WebRange_h
33 33
34 #include "public/platform/WebCommon.h" 34 #include "public/platform/WebCommon.h"
35 #if BLINK_IMPLEMENTATION
36 #include "core/editing/EphemeralRange.h"
37 #endif
35 38
36 namespace blink { 39 namespace blink {
37 40
41 class LocalFrame;
38 class Range; 42 class Range;
39 class WebString; 43 class WebString;
40 class LocalFrame;
41 44
42 class WebRange final { 45 class WebRange final {
43 public: 46 public:
44 BLINK_EXPORT WebRange(int start, int length); 47 BLINK_EXPORT WebRange(int start, int length);
45 48
46 int startOffset() const { return m_start; } 49 int startOffset() const { return m_start; }
47 int endOffset() const { return m_end; } 50 int endOffset() const { return m_end; }
48 int length() const { return m_end - m_start; } 51 int length() const { return m_end - m_start; }
49 52
50 bool isNull() const { return m_start == -1 && m_end == -1; } 53 bool isNull() const { return m_start == -1 && m_end == -1; }
51 54
52 #if BLINK_IMPLEMENTATION 55 #if BLINK_IMPLEMENTATION
53 WebRange(Range*); 56 WebRange(const EphemeralRange&);
54 57
55 Range* createRange(LocalFrame*) const; 58 EphemeralRange createEphemeralRange(LocalFrame*) const;
56 #endif 59 #endif
57 60
58 private: 61 private:
59 int m_start = -1; 62 int m_start = -1;
60 int m_end = -1; 63 int m_end = -1;
61 }; 64 };
62 65
63 } // namespace blink 66 } // namespace blink
64 67
65 #endif 68 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebRange.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698