Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/core/inspector/V8InspectorStringView.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/V8InspectorStringView.h
diff --git a/third_party/WebKit/Source/core/inspector/V8InspectorStringView.h b/third_party/WebKit/Source/core/inspector/V8InspectorStringView.h
new file mode 100644
index 0000000000000000000000000000000000000000..37e344cd7feedaec642d945a2f1cbc14aa6cf26c
--- /dev/null
+++ b/third_party/WebKit/Source/core/inspector/V8InspectorStringView.h
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8InspectorStringView_h
+#define V8InspectorStringView_h
+
+#include "core/CoreExport.h"
+#include "platform/inspector_protocol/InspectorProtocol.h"
+#include "platform/v8_inspector/public/StringView.h"
+#include "wtf/text/WTFString.h"
+
+namespace blink {
+
+// Note that passed strings must outlive the resulting StringView. This implies it must not be a temporary object.
+CORE_EXPORT v8_inspector::StringView toV8InspectorStringView(const String&);
esprehn 2016/08/19 18:53:12 just take a WTF::StringView
dgozman 2016/08/19 20:50:12 Done.
+CORE_EXPORT v8_inspector::StringView toV8InspectorStringView(const String16&);
+CORE_EXPORT v8_inspector::StringView toV8InspectorStringView(const char*);
esprehn 2016/08/19 18:53:12 remove this one
dgozman 2016/08/19 20:50:12 Done.
+CORE_EXPORT String toCoreString(const v8_inspector::StringView&);
+
+} // namespace blink
+
+#endif // V8InspectorStringView_h

Powered by Google App Engine
This is Rietveld 408576698