third_party/WebKit/Source/core/inspector/V8InspectorStringView.h - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/inspector/V8InspectorStringView.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp ('k') | third_party/WebKit/Source/core/inspector/V8InspectorStringView.cpp » ('j') | third_party/WebKit/Source/core/inspector/V8InspectorStringView.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef V8InspectorStringView_h

	6 #define V8InspectorStringView_h

	7

	8 #include "core/CoreExport.h"

	9 #include "platform/inspector_protocol/InspectorProtocol.h"

	10 #include "platform/v8_inspector/public/StringView.h"

	11 #include "wtf/text/WTFString.h"

	12

	13 namespace blink {

	14

	15 // Note that passed strings must outlive the resulting StringView. This implies it must not be a temporary object.

	16 CORE_EXPORT v8_inspector::StringView toV8InspectorStringView(const String&);
	esprehn 2016/08/19 18:53:12 just take a WTF::StringView just take a WTF::StringView dgozman 2016/08/19 20:50:12 Done. Show quoted text On 2016/08/19 18:53:12, esprehn wrote: > just take a WTF::StringView Done.
	17 CORE_EXPORT v8_inspector::StringView toV8InspectorStringView(const String16&);

	18 CORE_EXPORT v8_inspector::StringView toV8InspectorStringView(const char*);
	esprehn 2016/08/19 18:53:12 remove this one remove this one dgozman 2016/08/19 20:50:12 Done. Show quoted text On 2016/08/19 18:53:12, esprehn wrote: > remove this one Done.
	19 CORE_EXPORT String toCoreString(const v8_inspector::StringView&);

	20

	21 } // namespace blink

	22

	23 #endif // V8InspectorStringView_h

OLD	NEW