Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: styling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h
index ac68c1b0e9ea0a109a0818a0c46352dd79cb0924..a7f9b669058a16be18abc45475245002a339df5a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h
@@ -5,7 +5,8 @@
#ifndef V8StackTrace_h
#define V8StackTrace_h
-#include "platform/inspector_protocol/InspectorProtocol.h"
+#include "platform/v8_inspector/public/StringBuffer.h"
+#include "platform/v8_inspector/public/StringView.h"
#include "platform/v8_inspector/public/protocol/Runtime.h"
#include <v8.h>
@@ -15,15 +16,15 @@ namespace v8_inspector {
class V8StackTrace {
public:
virtual bool isEmpty() const = 0;
- virtual String16 topSourceURL() const = 0;
+ virtual StringView topSourceURL() const = 0;
virtual int topLineNumber() const = 0;
virtual int topColumnNumber() const = 0;
- virtual String16 topScriptId() const = 0;
- virtual String16 topFunctionName() const = 0;
+ virtual StringView topScriptId() const = 0;
+ virtual StringView topFunctionName() const = 0;
virtual ~V8StackTrace() { }
virtual std::unique_ptr<blink::protocol::Runtime::API::StackTrace> buildInspectorObject() const = 0;
- virtual String16 toString() const = 0;
+ virtual std::unique_ptr<StringBuffer> toString() const = 0;
// Safe to pass between threads, drops async chain.
virtual std::unique_ptr<V8StackTrace> clone() = 0;

Powered by Google App Engine
This is Rietveld 408576698