third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: styling Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h ('k') | third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef V8StackTrace_h	5 #ifndef V8StackTrace_h

6 #define V8StackTrace_h	6 #define V8StackTrace_h

7	7

8 #include "platform/inspector_protocol/InspectorProtocol.h"	8 #include "platform/v8_inspector/public/StringBuffer.h"

	9 #include "platform/v8_inspector/public/StringView.h"

9 #include "platform/v8_inspector/public/protocol/Runtime.h"	10 #include "platform/v8_inspector/public/protocol/Runtime.h"

10	11

11 #include <v8.h>	12 #include <v8.h>

12	13

13 namespace v8_inspector {	14 namespace v8_inspector {

14	15

15 class V8StackTrace {	16 class V8StackTrace {

16 public:	17 public:

17 virtual bool isEmpty() const = 0;	18 virtual bool isEmpty() const = 0;

18 virtual String16 topSourceURL() const = 0;	19 virtual StringView topSourceURL() const = 0;

19 virtual int topLineNumber() const = 0;	20 virtual int topLineNumber() const = 0;

20 virtual int topColumnNumber() const = 0;	21 virtual int topColumnNumber() const = 0;

21 virtual String16 topScriptId() const = 0;	22 virtual StringView topScriptId() const = 0;

22 virtual String16 topFunctionName() const = 0;	23 virtual StringView topFunctionName() const = 0;

23	24

24 virtual ~V8StackTrace() { }	25 virtual ~V8StackTrace() { }

25 virtual std::unique_ptr<blink::protocol::Runtime::API::StackTrace> buildInsp ectorObject() const = 0;	26 virtual std::unique_ptr<blink::protocol::Runtime::API::StackTrace> buildInsp ectorObject() const = 0;

26 virtual String16 toString() const = 0;	27 virtual std::unique_ptr<StringBuffer> toString() const = 0;

27	28

28 // Safe to pass between threads, drops async chain.	29 // Safe to pass between threads, drops async chain.

29 virtual std::unique_ptr<V8StackTrace> clone() = 0;	30 virtual std::unique_ptr<V8StackTrace> clone() = 0;

30 };	31 };

31	32

32 } // namespace v8_inspector	33 } // namespace v8_inspector

33	34

34 #endif // V8StackTrace_h	35 #endif // V8StackTrace_h

OLD	NEW