third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

index 782e5bbab014739c75726871ec7dc193b38f4843..3d56598aa6cb249aedaac4fcf88659578edbbade 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

@@ -134,9 +134,9 @@ void V8InjectedScriptHost::subtypeCallback(const v8::FunctionCallbackInfo<v8::Va

info.GetReturnValue().Set(toV8StringInternalized(isolate, "promise"));

return;

}

- String16 subtype = unwrapInspector(info)->client()->valueSubtype(value);

- if (!subtype.isEmpty()) {

- info.GetReturnValue().Set(toV8String(isolate, subtype));

+ std::unique_ptr<StringBuffer> subtype = unwrapInspector(info)->client()->valueSubtype(value);

+ if (subtype) {

+ info.GetReturnValue().Set(toV8String(isolate, subtype->string()));

return;

}