[DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h
index 2245c8fed6a94124d44d04ffacad1ceaad1d1055..661d52979ecbce53ff79267cf905b55ca5796325 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h
@@ -7,6 +7,7 @@
 
 #include "platform/inspector_protocol/InspectorProtocol.h"
 #include "platform/v8_inspector/protocol/Debugger.h"
+#include "platform/v8_inspector/public/String.h"
 #include <v8.h>
 
 namespace v8_inspector {
@@ -20,14 +21,33 @@ std::unique_ptr<protocol::Value> toProtocolValue(v8::Local<v8::Context>, v8::Loc
 v8::Local<v8::String> toV8String(v8::Isolate*, const String16&);
 v8::Local<v8::String> toV8StringInternalized(v8::Isolate*, const String16&);
 v8::Local<v8::String> toV8StringInternalized(v8::Isolate*, const char*);
+v8::Local<v8::String> toV8String(v8::Isolate*, const StringView&);
 
 String16 toProtocolString(v8::Local<v8::String>);
 String16 toProtocolStringWithTypeCheck(v8::Local<v8::Value>);
+String16 toString16(const StringView&);
+StringView toStringView(const String16&);
+
+bool stringViewStartsWith(const StringView&, const char*);
+std::unique_ptr<protocol::Value> parseJSON(const StringView& json);
 
 String16 findSourceURL(const String16& content, bool multiline);
 String16 findSourceMapURL(const String16& content, bool multiline);
 std::vector<std::unique_ptr<protocol::Debugger::SearchMatch>> searchInTextByLinesImpl(V8InspectorSession*, const String16& text, const String16& query, bool caseSensitive, bool isRegex);
 
+class StringBufferImpl : public StringBuffer {
+    PROTOCOL_DISALLOW_COPY(StringBufferImpl);
+public:
+    // Destroys string's content.
+    static std::unique_ptr<StringBufferImpl> create(String16&);

[caseq, 2016/08/22 17:53:02]

s/create/adopt/

This way you've got a pair of methods in base and derived class that have rather
different semantics.

[dgozman, 2016/08/22 22:35:19]

Done.

+    const StringView& string() override { return m_string; }
+
+private:
+    explicit StringBufferImpl(String16&);
+    std::unique_ptr<String16> m_owner;

[caseq, 2016/08/22 17:53:02]

can we just make it a member, i.e. drop unique_ptr<>?

[dgozman, 2016/08/22 22:35:19]

Yes. First version used to clear it, now we can just make it a member.

+    StringView m_string;
+};
+
 } //  namespace v8_inspector