chrome/browser/extensions/extension_service_unittest.cc - Issue 226023003: Create CrxInstaller directly in WebstoreInstaller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 226023003: Create CrxInstaller directly in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android compilation fix (again). Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index ee5039f28f2d1280426949bc5af27cc993b9db35..bbbff27cd49548bf7c9fbfc000b7342a6c604ee7 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -981,7 +981,7 @@ class ExtensionServiceTest

content::WindowedNotificationObserver observer(

chrome::NOTIFICATION_CRX_INSTALLER_DONE,

base::Bind(&IsCrxInstallerDone, &installer));

- service_->UpdateExtension(id, path, true, GURL(), &installer);

+ service_->UpdateExtension(id, path, true, &installer);

if (installer)

observer.Wait();

@@ -2789,7 +2789,7 @@ TEST_F(ExtensionServiceTest, UpdateExtensionDuringShutdown) {

// Update should fail and extension should not be updated.

path = data_dir_.AppendASCII("good2.crx");

- bool updated = service_->UpdateExtension(good_crx, path, true, GURL(), NULL);

+ bool updated = service_->UpdateExtension(good_crx, path, true, NULL);

ASSERT_FALSE(updated);

ASSERT_EQ("1.0.0.0",

service_->GetExtensionById(good_crx, false)->