chrome/browser/extensions/extension_service.cc - Issue 226023003: Create CrxInstaller directly in WebstoreInstaller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 226023003: Create CrxInstaller directly in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android compilation fix (again). Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index ee477c1f400e3ab3bf8488e87e2680745b6b72a6..4ef84138f36907c2f7e5039dfda2d96aec26c886 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -503,7 +503,6 @@ void ExtensionService::LoadGreylistFromPrefs() {

bool ExtensionService::UpdateExtension(const std::string& id,

const base::FilePath& extension_path,

bool file_ownership_passed,

- const GURL& download_url,

CrxInstaller** out_crx_installer) {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

if (browser_terminating_) {

@@ -583,7 +582,6 @@ bool ExtensionService::UpdateExtension(const std::string& id,

installer->set_creation_flags(creation_flags);

installer->set_delete_source(file_ownership_passed);

- installer->set_download_url(download_url);

installer->set_install_cause(extension_misc::INSTALL_CAUSE_UPDATE);

installer->InstallCrx(extension_path);