Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 226023003: Create CrxInstaller directly in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android compilation fix (again). Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_crx_util_android.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.h
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h
index 4d0b9653eb4a9fdf1db68e7a42f6e6754421e82f..8e3575bd4ff3a1fd3142afcb09c0b2deb2cd05e8 100644
--- a/chrome/browser/extensions/crx_installer.h
+++ b/chrome/browser/extensions/crx_installer.h
@@ -110,9 +110,6 @@ class CrxInstaller
int creation_flags() const { return creation_flags_; }
void set_creation_flags(int val) { creation_flags_ = val; }
- const GURL& download_url() const { return download_url_; }
- void set_download_url(const GURL& val) { download_url_ = val; }
-
const base::FilePath& source_file() const { return source_file_; }
Manifest::Location install_source() const {
@@ -146,14 +143,6 @@ class CrxInstaller
creation_flags_ &= ~Extension::FROM_WEBSTORE;
}
- // The original download URL should be set when the WebstoreInstaller is
- // tracking the installation. The WebstoreInstaller uses this URL to match
- // failure notifications to the extension.
- const GURL& original_download_url() const { return original_download_url_; }
- void set_original_download_url(const GURL& url) {
- original_download_url_ = url;
- }
-
// If |apps_require_extension_mime_type_| is set to true, be sure to set
// |original_mime_type_| as well.
void set_apps_require_extension_mime_type(
@@ -314,9 +303,6 @@ class CrxInstaller
// to false.
bool delete_source_;
- // The download URL, before redirects, if this is a gallery install.
- GURL original_download_url_;
-
// Whether to create an app shortcut after successful installation. This is
// set based on the user's selection in the UI and can only ever be true for
// apps.
« no previous file with comments | « chrome/browser/download/download_crx_util_android.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698