Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 226023003: Create CrxInstaller directly in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android compilation fix (again). Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index 3ef646a2ab51e59a21c082b1886976f64f482095..57d2a3692c9e1146f5eb17aae619267bfde42df5 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -167,6 +167,7 @@ CrxInstaller::CrxInstaller(
}
CrxInstaller::~CrxInstaller() {
+ LOG(WARNING) << "Destroying";
// Make sure the UI is deleted on the ui thread.
if (client_) {
BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, client_);
@@ -836,6 +837,7 @@ void CrxInstaller::NotifyCrxInstallComplete(bool success) {
void CrxInstaller::CleanupTempFiles() {
if (!installer_task_runner_->RunsTasksOnCurrentThread()) {
+ LOG(WARNING) << "Post CleanupTempFiles";
if (!installer_task_runner_->PostTask(
FROM_HERE,
base::Bind(&CrxInstaller::CleanupTempFiles, this))) {
@@ -844,6 +846,7 @@ void CrxInstaller::CleanupTempFiles() {
return;
}
+ LOG(WARNING) << "CleanupTempFiles";
// Delete the temp directory and crx file as necessary.
if (!temp_dir_.value().empty()) {
file_util::DeleteFile(temp_dir_, true);
« no previous file with comments | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698