Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 226023003: Create CrxInstaller directly in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index f9cfafa8e4a6e51a4e5fd0faa2ee6d50d18c4bdc..628e68d069f25fcb16d36ca94cb0c9e47524a0fe 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -337,7 +337,7 @@ void WebstoreInstaller::Observe(int type,
content::Details<const Extension>(details).ptr();
CrxInstaller* installer = content::Source<CrxInstaller>(source).ptr();
if (extension == NULL && download_item_ != NULL &&
- installer->download_url() == download_item_->GetURL() &&
+ installer->download_id() == download_item_->GetId() &&
installer->profile()->IsSameProfile(profile_)) {
ReportFailure(kInstallCanceledError, FAILURE_REASON_CANCELLED);
}
@@ -389,7 +389,7 @@ void WebstoreInstaller::Observe(int type,
const base::string16* error =
content::Details<const base::string16>(details).ptr();
const std::string utf8_error = base::UTF16ToUTF8(*error);
- if (download_url_ == crx_installer->original_download_url())
+ if (download_item_->GetId() == crx_installer->download_id())
ReportFailure(utf8_error, FAILURE_REASON_OTHER);
break;
}

Powered by Google App Engine
This is Rietveld 408576698