Create CrxInstaller directly in WebstoreInstaller

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index e897e265e86d16b8b89ec7e9f774ad9fc88aefab..ce925f1c0de00c29ec8864cb4eb64b3e006600cb 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -624,7 +624,6 @@ bool ExtensionService::UpdateExtension(const std::string& id,
   installer->set_creation_flags(creation_flags);
 
   installer->set_delete_source(file_ownership_passed);
-  installer->set_download_url(download_url);

[not at google - send to devlin, 2014/04/04 15:39:30]

why not setting download ID? was this always unnecessary?

[msimonides, 2014/04/07 07:23:38]

The download ID is not available here. But most importantly, the UpdateExtension
method isn't used by the WebstoreInstaller so the value isn't necessary and
wouldn't be used.

[not at google - send to devlin, 2014/04/07 16:51:40]

I see. It's weird that the download ID is a concern of CrxInstaller if only
WebstoreInstaller cares about it. Speaking of which I see several other
instantiations of WebstoreInstaller and only once place where the ID is set from
CrxInstaller, which originates from ChromeDownloadManagerDelegate. I'm confused.

   installer->set_install_cause(extension_misc::INSTALL_CAUSE_UPDATE);
   installer->InstallCrx(extension_path);