Create CrxInstaller directly in WebstoreInstaller

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 526 matching lines @@
     if (state == extensions::BLACKLISTED_SECURITY_VULNERABILITY ||
         state == extensions::BLACKLISTED_POTENTIALLY_UNWANTED ||
         state == extensions::BLACKLISTED_CWS_POLICY_VIOLATION)
       greylist_.Insert(*it);
   }
 }
 
 bool ExtensionService::UpdateExtension(const std::string& id,
                                        const base::FilePath& extension_path,
                                        bool file_ownership_passed,
                                        const GURL& download_url,

[asanka, 2014/04/07 15:26:00]

Nit: download_url is unused.

                                        CrxInstaller** out_crx_installer) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (browser_terminating_) {
     LOG(WARNING) << "Skipping UpdateExtension due to browser shutdown";
     // Leak the temp file at extension_path. We don't want to add to the disk
     // I/O burden at shutdown, we can't rely on the I/O completing anyway, and
     // the file is in the OS temp directory which should be cleaned up for us.
     return false;
   }
 
@@ skipping 59 matching lines @@
 
   if (extension && extension->was_installed_by_oem())
     creation_flags |= Extension::WAS_INSTALLED_BY_OEM;
 
   if (extension && extension->is_ephemeral())
     creation_flags |= Extension::IS_EPHEMERAL;
 
   installer->set_creation_flags(creation_flags);
 
   installer->set_delete_source(file_ownership_passed);
-  installer->set_download_url(download_url);

[not at google - send to devlin, 2014/04/04 15:39:30]

why not setting download ID? was this always unnecessary?

[msimonides, 2014/04/07 07:23:38]

The download ID is not available here. But most importantly, the UpdateExtension
method isn't used by the WebstoreInstaller so the value isn't necessary and
wouldn't be used.

[not at google - send to devlin, 2014/04/07 16:51:40]

I see. It's weird that the download ID is a concern of CrxInstaller if only
WebstoreInstaller cares about it. Speaking of which I see several other
instantiations of WebstoreInstaller and only once place where the ID is set from
CrxInstaller, which originates from ChromeDownloadManagerDelegate. I'm confused.

   installer->set_install_cause(extension_misc::INSTALL_CAUSE_UPDATE);
   installer->InstallCrx(extension_path);
 
   if (out_crx_installer)
     *out_crx_installer = installer.get();
 
   return true;
 }
 
 void ExtensionService::ReloadExtension(const std::string extension_id) {
@@ skipping 2018 matching lines @@
 void ExtensionService::UnloadAllExtensionsInternal() {
   profile_->GetExtensionSpecialStoragePolicy()->RevokeRightsForAllExtensions();
 
   registry_->ClearAll();
   system_->runtime_data()->ClearAll();
 
   // TODO(erikkay) should there be a notification for this?  We can't use
   // EXTENSION_UNLOADED since that implies that the extension has been disabled
   // or uninstalled.
 }