Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2260183003: Remove unused default argument value in ExpressionClassifier::Accumulate (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused default argument value in ExpressionClassifier::Accumulate Also removed the "StandardProductions" enum value as its name is unhelpful in deciding when to use it (and it only had a single reference). R=gsathya@chromium.org Committed: https://crrev.com/7da873b73fa22473573baa27f641a1d07a357121 Cr-Commit-Position: refs/heads/master@{#38763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/parsing/expression-classifier.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years, 4 months ago (2016-08-19 18:53:47 UTC) #1
gsathya
lgtm
4 years, 4 months ago (2016-08-19 19:10:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260183003/1
4 years, 4 months ago (2016-08-19 19:12:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 19:53:26 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 19:53:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7da873b73fa22473573baa27f641a1d07a357121
Cr-Commit-Position: refs/heads/master@{#38763}

Powered by Google App Engine
This is Rietveld 408576698