Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/parsing/expression-classifier.h

Issue 2260183003: Remove unused default argument value in ExpressionClassifier::Accumulate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/expression-classifier.h
diff --git a/src/parsing/expression-classifier.h b/src/parsing/expression-classifier.h
index 8e13d0e503756a4c841919348590e7abb302e31d..2c555b9c9886fa28972024f0ebd187c665c28ee7 100644
--- a/src/parsing/expression-classifier.h
+++ b/src/parsing/expression-classifier.h
@@ -71,11 +71,10 @@ class ExpressionClassifier {
LetPatternProduction | AsyncBindingPatternProduction),
FormalParametersProductions = (DistinctFormalParametersProduction |
StrictModeFormalParametersProduction),
- StandardProductions = ExpressionProductions | PatternProductions,
AllProductions =
- (StandardProductions | FormalParametersProductions |
- ArrowFormalParametersProduction | CoverInitializedNameProduction |
- AsyncArrowFormalParametersProduction | AsyncBindingPatternProduction)
+ (ExpressionProductions | PatternProductions |
+ FormalParametersProductions | ArrowFormalParametersProduction |
+ CoverInitializedNameProduction | AsyncArrowFormalParametersProduction)
};
enum FunctionProperties : unsigned {
@@ -345,8 +344,7 @@ class ExpressionClassifier {
invalid_productions_ &= ~AssignmentPatternProduction;
}
- void Accumulate(ExpressionClassifier* inner,
- unsigned productions = StandardProductions,
+ void Accumulate(ExpressionClassifier* inner, unsigned productions,
bool merge_non_patterns = true) {
DCHECK_EQ(inner->reported_errors_, reported_errors_);
DCHECK_EQ(inner->reported_errors_begin_, reported_errors_end_);
« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698