Files: Extract VolumeInfo interface from volume_manager.js.

Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the VolumeInfo's interface
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler

Committed: https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0
Cr-Commit-Position: refs/heads/master@{#413423}

[fukino, 2016-08-19 07:42:46]

Description was changed from

==========
Files: Extract VolumeInfo interface from volume_manager.js.

BUG=636289
TEST=third_party/closure_compiler/run_compiler
==========

to

==========
Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the
VolumeInfo's interface don't need to have dependencies on the VolumeInfo's
implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler
==========

[fukino, 2016-08-19 07:43:02]

Description was changed from

==========
Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the
VolumeInfo's interface don't need to have dependencies on the VolumeInfo's
implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler
==========

to

==========
Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the
VolumeInfo's interface 
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler
==========

[fukino, 2016-08-19 07:43:23]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[fukino, 2016-08-19 07:43:23]

PTAL

[fukino, 2016-08-19 07:43:46]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 07:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 08:37:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 08:37:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-08-21 22:15:37]

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
File ui/file_manager/externs/volume_info.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:6: * @interface
Please add comments. You can move comments from VolumeInfoImpl.
Ditto for other values.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/volume_manager.js:33: function
VolumeInfoImpl(
Why don't you extract VolumeInfoImpl into a separete file?
I feel it's worthwhile to improve readability.

[oka, 2016-08-22 01:58:07]

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
File ui/file_manager/externs/volume_info.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:14: VolumeInfo.prototype.volumeId;
Could you elabolate what is this for? Add example volume ID?

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:20: VolumeInfo.prototype.displayRoot;
Move comments from VolumeInfoImpl.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:23: VolumeInfo.prototype.fakeEntries;
Add a comment; what is this for?

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:26: VolumeInfo.prototype.error;
Add comment.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:29: VolumeInfo.prototype.deviceType;
Add comment.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:32: VolumeInfo.prototype.devicePath;
Add comment.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:38: VolumeInfo.prototype.profile;
Could you add an example of |displayName|?

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:41: VolumeInfo.prototype.label;
Could you add an example of |label|?

[fukino, 2016-08-22 05:32:48]

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
File ui/file_manager/externs/volume_info.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:6: * @interface
On 2016/08/21 22:15:37, oka wrote:
> Please add comments. You can move comments from VolumeInfoImpl.
> Ditto for other values.

Done.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:14: VolumeInfo.prototype.volumeId;
On 2016/08/22 01:58:06, oka wrote:
> Could you elabolate what is this for? Add example volume ID?

I annotated it as just "The ID of the volume.", since the role is just
identifying the volume, and we shouldn't have any expectation to the content.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:20: VolumeInfo.prototype.displayRoot;
On 2016/08/22 01:58:07, oka wrote:
> Move comments from VolumeInfoImpl.

Done.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:23: VolumeInfo.prototype.fakeEntries;
On 2016/08/22 01:58:07, oka wrote:
> Add a comment; what is this for?

Done.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:26: VolumeInfo.prototype.error;
On 2016/08/22 01:58:07, oka wrote:
> Add comment.

Done.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:29: VolumeInfo.prototype.deviceType;
On 2016/08/22 01:58:06, oka wrote:
> Add comment.

Done.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:32: VolumeInfo.prototype.devicePath;
On 2016/08/22 01:58:07, oka wrote:
> Add comment.

Done.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:38: VolumeInfo.prototype.profile;
On 2016/08/22 01:58:07, oka wrote:
> Could you add an example of |displayName|?

foobar@chromium.org. However, let me describe the profile's properties in a
separate annotation. (We'll define an extern for the Profile later.)

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:41: VolumeInfo.prototype.label;
On 2016/08/22 01:58:06, oka wrote:
> Could you add an example of |label|?

Done.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/volume_manager.js:33: function
VolumeInfoImpl(
On 2016/08/21 22:15:37, oka wrote:
> Why don't you extract VolumeInfoImpl into a separete file?
> I feel it's worthwhile to improve readability.

I'll split it into a separate file after crbug.com/639225 not to increase the
number of http requests in the background script.

[oka, 2016-08-22 06:51:09]

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
File ui/file_manager/externs/volume_info.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:14: VolumeInfo.prototype.volumeId;
On 2016/08/22 05:32:47, fukino wrote:
> On 2016/08/22 01:58:06, oka wrote:
> > Could you elabolate what is this for? Add example volume ID?
> 
> I annotated it as just "The ID of the volume.", since the role is just
> identifying the volume, and we shouldn't have any expectation to the content.

Acknowledged. You could remove the comment then.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:38: VolumeInfo.prototype.profile;
On 2016/08/22 05:32:48, fukino wrote:
> On 2016/08/22 01:58:07, oka wrote:
> > Could you add an example of |displayName|?
> 
> mailto:foobar@chromium.org. However, let me describe the profile's properties
in a
> separate annotation. (We'll define an extern for the Profile later.)

Acknowledged.

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/volume_manager.js:33: function
VolumeInfoImpl(
On 2016/08/22 05:32:48, fukino wrote:
> On 2016/08/21 22:15:37, oka wrote:
> > Why don't you extract VolumeInfoImpl into a separete file?
> > I feel it's worthwhile to improve readability.
> 
> I'll split it into a separate file after crbug.com/639225 not to increase the
> number of http requests in the background script.

Acknowledged.

https://codereview.chromium.org/2260133002/diff/20001/ui/file_manager/externs...
File ui/file_manager/externs/volume_info.js (right):

https://codereview.chromium.org/2260133002/diff/20001/ui/file_manager/externs...
ui/file_manager/externs/volume_info.js:98: *
Revert? Or add a comment.

[oka, 2016-08-22 07:03:40]

lgtm

[oka, 2016-08-22 07:04:28]

lgtm with nits.

[fukino, 2016-08-22 08:50:57]

Thank you!

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
File ui/file_manager/externs/volume_info.js (right):

https://codereview.chromium.org/2260133002/diff/1/ui/file_manager/externs/vol...
ui/file_manager/externs/volume_info.js:14: VolumeInfo.prototype.volumeId;
On 2016/08/22 06:51:09, oka wrote:
> On 2016/08/22 05:32:47, fukino wrote:
> > On 2016/08/22 01:58:06, oka wrote:
> > > Could you elabolate what is this for? Add example volume ID?
> > 
> > I annotated it as just "The ID of the volume.", since the role is just
> > identifying the volume, and we shouldn't have any expectation to the
content.
> 
> Acknowledged. You could remove the comment then.

Thanks! Removed.

https://codereview.chromium.org/2260133002/diff/20001/ui/file_manager/externs...
File ui/file_manager/externs/volume_info.js (right):

https://codereview.chromium.org/2260133002/diff/20001/ui/file_manager/externs...
ui/file_manager/externs/volume_info.js:98: *
On 2016/08/22 06:51:09, oka wrote:
> Revert? Or add a comment.

Done.

[fukino, 2016-08-22 08:51:05]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-08-22 08:51:06]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2260133002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-08-22 08:51:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 09:30:39]

Description was changed from

==========
Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the
VolumeInfo's interface 
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler
==========

to

==========
Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the
VolumeInfo's interface 
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler
==========

[commit-bot: I haz the power, 2016-08-22 09:30:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 09:32:24]

Description was changed from

==========
Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the
VolumeInfo's interface 
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler
==========

to

==========
Files: Extract VolumeInfo interface from volume_manager.js.

Extracted VolumeInfo interface so that our modules which depend on only the
VolumeInfo's interface
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler

Committed: https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0
Cr-Commit-Position: refs/heads/master@{#413423}
==========

[commit-bot: I haz the power, 2016-08-22 09:32:25]

Patchset 3 (id:??) landed as
https://crrev.com/d54cfea10b58af54234c0c29ce2df19ea2e860d0
Cr-Commit-Position: refs/heads/master@{#413423}