ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp - Issue 2260133002: Files: Extract VolumeInfo interface from volume_manager.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

Issue 2260133002: Files: Extract VolumeInfo interface from volume_manager.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/compiled_resources.gyp ('k') | ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

diff --git a/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp b/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

index 05ba830e629ee6cbe6e391518e03fb013928f631..7a9c35e4348b16590260aca5cca5091286ce6806 100644

--- a/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

+++ b/ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp

@@ -27,10 +27,10 @@

# 'target_name': 'dialog_action_controller',

# 'includes': ['../../../compile_js2.gypi'],

# },

-# {

-# 'target_name': 'dialog_type',

-# 'includes': ['../../../compile_js2.gypi'],

-# },

+ {

+ 'target_name': 'dialog_type',

+ 'includes': ['../../../compile_js2.gypi'],

+ },

# {

# 'target_name': 'directory_contents',

# 'includes': ['../../../compile_js2.gypi'],

@@ -103,10 +103,14 @@

# 'target_name': 'import_controller_unittest',

# 'includes': ['../../../compile_js2.gypi'],

# },

-# {

-# 'target_name': 'launch_param',

-# 'includes': ['../../../compile_js2.gypi'],

-# },

+ {

+ 'target_name': 'launch_param',

+ 'dependencies': [

+ '../../common/js/compiled_resources2.gyp:volume_manager_common',

+ 'dialog_type',

+ ],

+ 'includes': ['../../../compile_js2.gypi'],

+ },

# {

# 'target_name': 'list_thumbnail_loader',

# 'includes': ['../../../compile_js2.gypi'],