Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2260023002: [ios] String updates for Update Password infobar (Closed)

Created:
4 years, 4 months ago by Jackie Quinn
Modified:
4 years, 4 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] String updates for Update Password infobar Drop "Google" from password manager branding in the update password infobar to simplify the text, and always say "your password" rather than "the password" BUG=639093 Committed: https://crrev.com/db9b1f49ee46b472f40d182bc4fee19cc15b93fc Cr-Commit-Position: refs/heads/master@{#413183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M ios/chrome/app/strings/ios_chromium_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/app/strings/ios_google_chrome_strings.grd View 1 chunk +1 line, -4 lines 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jackie Quinn
vabr@ for delegate (and fyi), rohitrao@ for strings.
4 years, 4 months ago (2016-08-18 21:53:46 UTC) #2
vabr (Chromium)
LGTM, thanks a lot, Jackie! Vaclav
4 years, 4 months ago (2016-08-19 07:57:01 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years, 4 months ago (2016-08-19 11:02:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260023002/1
4 years, 4 months ago (2016-08-19 17:08:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 17:52:10 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 17:58:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db9b1f49ee46b472f40d182bc4fee19cc15b93fc
Cr-Commit-Position: refs/heads/master@{#413183}

Powered by Google App Engine
This is Rietveld 408576698