Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2260003002: [ios] Set WebState::IsLoading flag to false if load is cancelled. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[ios] Set WebState::IsLoading flag to false if load is cancelled. Before this change WebState::IsLoading was returning false which caused Toolbar to think that page did not finish loading. In M52 and earlier toolbar was relying to CRWWebController.loadPhase API to check the load state so this bug is M53 regression. Keeping WebState::IsLoading in sync with CRWWebController.loadPhase fixes toobar bug and is generally a reasonable thing to do. BUG=638277 Review-Url: https://codereview.chromium.org/2250563003 Cr-Commit-Position: refs/heads/master@{#412391} (cherry picked from commit 16e4de4de55c5c946b8bdfa47bfee274afc930f2) Committed: https://chromium.googlesource.com/chromium/src/+/aa1c693955107d0e4d43ed59ebabe974ee698665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-18 21:04:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa1c693955107d0e4d43ed59ebabe974ee698665.

Powered by Google App Engine
This is Rietveld 408576698