Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2250563003: [ios] Set WebState::IsLoading flag to false if load is cancelled. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Set WebState::IsLoading flag to false if load is cancelled. Before this change WebState::IsLoading was returning false which caused Toolbar to think that page did not finish loading. In M52 and earlier toolbar was relying to CRWWebController.loadPhase API to check the load state so this bug is M53 regression. Keeping WebState::IsLoading in sync with CRWWebController.loadPhase fixes toobar bug and is generally a reasonable thing to do. BUG=638277 Committed: https://crrev.com/16e4de4de55c5c946b8bdfa47bfee274afc930f2 Cr-Commit-Position: refs/heads/master@{#412391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-16 23:06:49 UTC) #4
kkhorimoto
lgtm
4 years, 4 months ago (2016-08-16 23:09:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250563003/1
4 years, 4 months ago (2016-08-17 00:04:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 00:09:50 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 00:11:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16e4de4de55c5c946b8bdfa47bfee274afc930f2
Cr-Commit-Position: refs/heads/master@{#412391}

Powered by Google App Engine
This is Rietveld 408576698