Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2259983003: Add a choice not to crash when unexpected dirty layout is encountered (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
Reviewers:
szager1
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a choice not to crash when unexpected dirty layout is encountered If choose not to crash, the callsite can choose to ignore the result or early return from the function. BUG=590856 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/374adf05752934deb4a2be54b8a1c2d76f13836c Cr-Commit-Position: refs/heads/master@{#413358}

Patch Set 1 #

Patch Set 2 : add todos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -21 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 5 chunks +36 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Xianzhu
4 years, 4 months ago (2016-08-19 01:44:55 UTC) #5
szager1
lgtm with nit: please add TODO's at the location of every early return that indicates ...
4 years, 4 months ago (2016-08-19 18:32:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259983003/20001
4 years, 4 months ago (2016-08-20 23:36:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-21 01:29:21 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 01:30:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/374adf05752934deb4a2be54b8a1c2d76f13836c
Cr-Commit-Position: refs/heads/master@{#413358}

Powered by Google App Engine
This is Rietveld 408576698