Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/core/paint/FramePainter.cpp

Issue 2259983003: Add a choice not to crash when unexpected dirty layout is encountered (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add todos Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/FramePainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/FramePainter.cpp b/third_party/WebKit/Source/core/paint/FramePainter.cpp
index 6198b01079c979c82a7cbebca183f88953e9b6f2..cc4d7297e8c2df17c5b0e10019c48d90bde12d44 100644
--- a/third_party/WebKit/Source/core/paint/FramePainter.cpp
+++ b/third_party/WebKit/Source/core/paint/FramePainter.cpp
@@ -104,7 +104,10 @@ void FramePainter::paintContents(GraphicsContext& context, const GlobalPaintFlag
return;
}
- frameView().checkDoesNotNeedLayout();
+ // TODO(crbug.com/590856): It's still broken when we choose not to crash when the check fails.
+ if (!frameView().checkDoesNotNeedLayout())
+ return;
+
// TODO(wangxianzhu): The following check should be stricter, but currently this is blocked
// by the svg root issue (crbug.com/442939).
ASSERT(document->lifecycle().state() >= DocumentLifecycle::CompositingClean);
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698