[layoutng] Margin support, part 1

[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/aec3029745fe492e73bc419ab4fc9844c3a0191d
Cr-Commit-Position: refs/heads/master@{#413239}

[cbiesinger, 2016-08-18 20:18:51]

Description was changed from

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
==========

to

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
==========

[cbiesinger, 2016-08-18 20:19:14]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 20:19:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-18 22:32:46]

LGTM

[ikilpatrick, 2016-08-18 22:54:33]

lgtm

https://codereview.chromium.org/2259963002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2259963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:43: if (type !=
LengthResolveType::MarginSize && length.isAuto())
is this needed? should there just be a DCHECK(type !=
LengthResolveType::MarginSize) at the top?

[commit-bot: I haz the power, 2016-08-19 01:07:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 01:07:46]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cbiesinger, 2016-08-19 01:16:44]

On 2016/08/18 22:54:33, ikilpatrick wrote:
> lgtm
> 
>
https://codereview.chromium.org/2259963002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):
> 
>
https://codereview.chromium.org/2259963002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:43: if (type !=
> LengthResolveType::MarginSize && length.isAuto())
> is this needed? should there just be a DCHECK(type !=
> LengthResolveType::MarginSize) at the top?

Yeah maybe you're right. The reason I allowed it was for a potential future in
which we resolve flex/grid margins the way the spec originally envisioned it
(before it was changed to allow either way). But that's probably too much
future-proofing -- I'll add a DCHECK.

[cbiesinger, 2016-08-19 17:29:07]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-08-19 17:29:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2259963002/#ps20001
(title: "dcheck")

[commit-bot: I haz the power, 2016-08-19 17:29:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-19 21:09:00]

Description was changed from

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
==========

to

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

[cbiesinger, 2016-08-19 21:09:22]

The CQ bit was unchecked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:09:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:09:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cbiesinger, 2016-08-19 21:09:38]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 21:18:56]

Description was changed from

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

[commit-bot: I haz the power, 2016-08-19 21:18:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 21:23:02]

Description was changed from

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true
==========

to

==========
[layoutng] Margin support, part 1

Support margins for positioning children.

Still to be done:
- margin: auto
- margins need to affect the size computation

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
NOTRY=true

Committed: https://crrev.com/aec3029745fe492e73bc419ab4fc9844c3a0191d
Cr-Commit-Position: refs/heads/master@{#413239}
==========

[commit-bot: I haz the power, 2016-08-19 21:23:03]

Patchset 2 (id:??) landed as
https://crrev.com/aec3029745fe492e73bc419ab4fc9844c3a0191d
Cr-Commit-Position: refs/heads/master@{#413239}