Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

Issue 2259963002: [layoutng] Margin support, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dcheck Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_length_utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_block_layout_algorithm.h" 5 #include "core/layout/ng/ng_block_layout_algorithm.h"
6 6
7 #include "core/layout/LayoutBox.h" 7 #include "core/layout/LayoutBox.h"
8 #include "core/layout/ng/ng_constraint_space.h" 8 #include "core/layout/ng/ng_constraint_space.h"
9 #include "core/layout/ng/ng_fragment.h" 9 #include "core/layout/ng/ng_fragment.h"
10 #include "core/layout/ng/ng_length_utils.h" 10 #include "core/layout/ng/ng_length_utils.h"
11 #include "core/layout/ng/ng_margin_strut.h"
11 #include "core/style/ComputedStyle.h" 12 #include "core/style/ComputedStyle.h"
12 #include "platform/LengthFunctions.h" 13 #include "platform/LengthFunctions.h"
13 14
14 namespace blink { 15 namespace blink {
15 16
16 NGBlockLayoutAlgorithm::NGBlockLayoutAlgorithm( 17 NGBlockLayoutAlgorithm::NGBlockLayoutAlgorithm(
17 PassRefPtr<const ComputedStyle> style, 18 PassRefPtr<const ComputedStyle> style,
18 NGBoxIterator boxIterator) 19 NGBoxIterator boxIterator)
19 : m_style(style), m_boxIterator(boxIterator) {} 20 : m_style(style), m_boxIterator(boxIterator) {}
20 21
21 NGFragment* NGBlockLayoutAlgorithm::layout( 22 NGFragment* NGBlockLayoutAlgorithm::layout(
22 const NGConstraintSpace& constraintSpace) { 23 const NGConstraintSpace& constraintSpace) {
23 LayoutUnit inlineSize = 24 LayoutUnit inlineSize =
24 computeInlineSizeForFragment(constraintSpace, *m_style); 25 computeInlineSizeForFragment(constraintSpace, *m_style);
25 26
26 HeapVector<Member<const NGFragmentBase>> childFragments; 27 HeapVector<Member<const NGFragmentBase>> childFragments;
27 LayoutUnit contentSize; 28 LayoutUnit contentSize;
28 for (NGBox box : m_boxIterator) { 29 for (NGBox box : m_boxIterator) {
30 NGBoxMargins childMargins = computeMargins(constraintSpace, *box.style());
29 NGFragment* fragment = box.layout(constraintSpace); 31 NGFragment* fragment = box.layout(constraintSpace);
30 // TODO(layout-ng): Take margins into account 32 // TODO(layout-ng): Support auto margins
31 fragment->setOffset(LayoutUnit(), contentSize); 33 fragment->setOffset(childMargins.inlineStart,
34 contentSize + childMargins.blockStart);
32 box.positionUpdated(*fragment); 35 box.positionUpdated(*fragment);
33 contentSize += fragment->blockSize(); 36 contentSize += fragment->blockSize() + childMargins.blockSum();
34 childFragments.append(fragment); 37 childFragments.append(fragment);
35 } 38 }
36 39
37 LayoutUnit blockSize = 40 LayoutUnit blockSize =
38 computeBlockSizeForFragment(constraintSpace, *m_style, contentSize); 41 computeBlockSizeForFragment(constraintSpace, *m_style, contentSize);
39 NGFragment* returnFragment = 42 NGFragment* returnFragment =
40 new NGFragment(inlineSize, blockSize, inlineSize, blockSize, 43 new NGFragment(inlineSize, blockSize, inlineSize, blockSize,
41 HorizontalTopBottom, LeftToRight); 44 HorizontalTopBottom, LeftToRight);
42 returnFragment->swapChildren(childFragments); 45 returnFragment->swapChildren(childFragments);
43 return returnFragment; 46 return returnFragment;
44 } 47 }
45 48
46 } // namespace blink 49 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_length_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698