Add a unit test expection for calling the render scheduler on coalesced events.

Add a unit test expection for calling the render scheduler on coalesced events.

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640
Committed: https://crrev.com/dad74f04e448eab5ecbdbd06e087d5780bdfa065
Cr-Commit-Position: refs/heads/master@{#413442}

[dtapuska, 2016-08-19 15:14:37]

Description was changed from

==========
Add a unit test expection for calling the render scheduler on coalesced events.

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640
==========

to

==========
Add a unit test expection for calling the render scheduler on coalesced events.

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640
==========

[dtapuska, 2016-08-19 15:14:38]

dtapuska@chromium.org changed reviewers:
+ skyostil@chromium.org, tdresser@chromium.org

[dtapuska, 2016-08-19 15:15:08]

I've provided a mock impl of the blink scheduler and assert that we correctly
call it in this unit test.

[Sami, 2016-08-19 15:23:29]

skyostil@chromium.org changed reviewers:
+ alexclarke@chromium.org

[Sami, 2016-08-19 15:23:58]

Alex just spent some time cleaning up the various scheduler mocks. Alex, can you
suggest a way to avoid adding another one here?

[dtapuska, 2016-08-19 15:29:31]

On 2016/08/19 15:23:58, Sami wrote:
> Alex just spent some time cleaning up the various scheduler mocks. Alex, can
you
> suggest a way to avoid adding another one here?

The ones I found nobody used gmock which are usually ones I find in the testing.
I can certainly move the mock file into the testing directory.

[tdresser, 2016-08-19 15:38:20]

LGTM

https://codereview.chromium.org/2259823007/diff/1/content/renderer/input/inpu...
File content/renderer/input/input_event_filter.cc (right):

https://codereview.chromium.org/2259823007/diff/1/content/renderer/input/inpu...
content/renderer/input/input_event_filter.cc:57: renderer_scheduler_(NULL) {
Should we take the renderer scheduler as a parameter?
It might simplify mocking some tests in the future.

Either way is fine by me though.

[alex clarke (OOO till 29th), 2016-08-19 15:38:32]

On 2016/08/19 15:23:58, Sami wrote:
> Alex just spent some time cleaning up the various scheduler mocks. Alex, can
you
> suggest a way to avoid adding another one here?

There is a FakeRendererScheduler and a FakeWebTaskRunner in
public/platform/scheduler/test/
These are basically null classes.  I think there's room for a GMock style mock
too since the actual scheduler is too heavyweight for unit testing this sort of
stuff.

Whatever we do I'd like to centralize scheduler mocks and fake classes so it's
easy to make API changes.

[dtapuska, 2016-08-19 16:03:20]

On 2016/08/19 15:38:32, alex clarke wrote:
> On 2016/08/19 15:23:58, Sami wrote:
> > Alex just spent some time cleaning up the various scheduler mocks. Alex, can
> you
> > suggest a way to avoid adding another one here?
> 
> There is a FakeRendererScheduler and a FakeWebTaskRunner in
> public/platform/scheduler/test/
> These are basically null classes.  I think there's room for a GMock style mock
> too since the actual scheduler is too heavyweight for unit testing this sort
of
> stuff.
> 
> Whatever we do I'd like to centralize scheduler mocks and fake classes so it's
> easy to make API changes.

Ok I've moved the mock into the testing directory. Does this look ok?

[dtapuska, 2016-08-19 16:03:33]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 16:03:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-08-19 16:05:53]

lgtm

[commit-bot: I haz the power, 2016-08-19 17:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 17:55:55]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2016-08-19 19:08:31]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-08-19 19:08:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2259823007/#ps20001
(title: "Move mock into testing directory")

[commit-bot: I haz the power, 2016-08-19 19:09:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 19:16:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:16:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dtapuska, 2016-08-19 19:24:16]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-08-19 19:24:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2259823007/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-19 19:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:59:40]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2016-08-22 13:03:23]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-08-22 13:03:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 14:55:20]

Description was changed from

==========
Add a unit test expection for calling the render scheduler on coalesced events.

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640
==========

to

==========
Add a unit test expection for calling the render scheduler on coalesced events.

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640
==========

[commit-bot: I haz the power, 2016-08-22 14:55:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 14:56:51]

Description was changed from

==========
Add a unit test expection for calling the render scheduler on coalesced events.

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640
==========

to

==========
Add a unit test expection for calling the render scheduler on coalesced events.

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640

Committed: https://crrev.com/dad74f04e448eab5ecbdbd06e087d5780bdfa065
Cr-Commit-Position: refs/heads/master@{#413442}
==========

[commit-bot: I haz the power, 2016-08-22 14:56:53]

Patchset 3 (id:??) landed as
https://crrev.com/dad74f04e448eab5ecbdbd06e087d5780bdfa065
Cr-Commit-Position: refs/heads/master@{#413442}