Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: content/renderer/input/main_thread_event_queue.cc

Issue 2259823007: Add a unit test expection for calling the render scheduler on coalesced events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/main_thread_event_queue.cc
diff --git a/content/renderer/input/main_thread_event_queue.cc b/content/renderer/input/main_thread_event_queue.cc
index b3b4b89a5997a04bf61c8151afaae75dd62f2ff2..8c1b8675cfafb469d36ae1841c51a4d9256fe32e 100644
--- a/content/renderer/input/main_thread_event_queue.cc
+++ b/content/renderer/input/main_thread_event_queue.cc
@@ -6,7 +6,6 @@
#include "content/common/input/event_with_latency_info.h"
#include "content/common/input_messages.h"
-#include "content/renderer/render_thread_impl.h"
namespace content {
@@ -39,14 +38,16 @@ void EventWithDispatchType::CoalesceWith(const EventWithDispatchType& other) {
MainThreadEventQueue::MainThreadEventQueue(
int routing_id,
MainThreadEventQueueClient* client,
- const scoped_refptr<base::SingleThreadTaskRunner>& main_task_runner)
+ const scoped_refptr<base::SingleThreadTaskRunner>& main_task_runner,
+ blink::scheduler::RendererScheduler* renderer_scheduler)
: routing_id_(routing_id),
client_(client),
is_flinging_(false),
last_touch_start_forced_nonblocking_due_to_fling_(false),
enable_fling_passive_listener_flag_(base::FeatureList::IsEnabled(
features::kPassiveEventListenersDueToFling)),
- main_task_runner_(main_task_runner) {}
+ main_task_runner_(main_task_runner),
+ renderer_scheduler_(renderer_scheduler) {}
MainThreadEventQueue::~MainThreadEventQueue() {}
@@ -134,13 +135,12 @@ void MainThreadEventQueue::PopEventOnMainThread() {
void MainThreadEventQueue::EventHandled(blink::WebInputEvent::Type type,
InputEventAckState ack_result) {
if (in_flight_event_) {
- RenderThreadImpl* render_thread_impl = RenderThreadImpl::current();
// Send acks for blocking touch events.
for (const auto id : in_flight_event_->eventsToAck()) {
client_->SendInputEventAck(routing_id_, type, ack_result, id);
- if (render_thread_impl) {
- render_thread_impl->GetRendererScheduler()
- ->DidHandleInputEventOnMainThread(in_flight_event_->event());
+ if (renderer_scheduler_) {
+ renderer_scheduler_->DidHandleInputEventOnMainThread(
+ in_flight_event_->event());
}
}
}
« no previous file with comments | « content/renderer/input/main_thread_event_queue.h ('k') | content/renderer/input/main_thread_event_queue_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698