Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: net/http/http_stream_parser_unittest.cc

Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller_unittest.cc ('k') | net/http/mock_http_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_parser_unittest.cc
diff --git a/net/http/http_stream_parser_unittest.cc b/net/http/http_stream_parser_unittest.cc
index b4d9872f6bbc8e94547a43524e373eb75767f3e3..1468163eea107b30be44af528eded8955e904a49 100644
--- a/net/http/http_stream_parser_unittest.cc
+++ b/net/http/http_stream_parser_unittest.cc
@@ -241,8 +241,9 @@ TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_NoBody) {
TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_EmptyBody) {
std::vector<std::unique_ptr<UploadElementReader>> element_readers;
- std::unique_ptr<UploadDataStream> body(base::WrapUnique(
- new ElementsUploadDataStream(std::move(element_readers), 0)));
+ std::unique_ptr<UploadDataStream> body(
+ base::MakeUnique<ElementsUploadDataStream>(std::move(element_readers),
+ 0));
ASSERT_THAT(body->Init(CompletionCallback(), BoundNetLog()), IsOk());
// Shouldn't be merged if upload data is empty.
ASSERT_FALSE(HttpStreamParser::ShouldMergeRequestHeadersAndBody(
@@ -270,9 +271,9 @@ TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_FileBody) {
{
std::vector<std::unique_ptr<UploadElementReader>> element_readers;
- element_readers.push_back(base::WrapUnique(
- new UploadFileElementReader(base::ThreadTaskRunnerHandle::Get().get(),
- temp_file_path, 0, 0, base::Time())));
+ element_readers.push_back(base::MakeUnique<UploadFileElementReader>(
+ base::ThreadTaskRunnerHandle::Get().get(), temp_file_path, 0, 0,
+ base::Time()));
std::unique_ptr<UploadDataStream> body(
new ElementsUploadDataStream(std::move(element_readers), 0));
@@ -292,8 +293,8 @@ TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_FileBody) {
TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_SmallBodyInMemory) {
std::vector<std::unique_ptr<UploadElementReader>> element_readers;
const std::string payload = "123";
- element_readers.push_back(base::WrapUnique(
- new UploadBytesElementReader(payload.data(), payload.size())));
+ element_readers.push_back(base::MakeUnique<UploadBytesElementReader>(
+ payload.data(), payload.size()));
std::unique_ptr<UploadDataStream> body(
new ElementsUploadDataStream(std::move(element_readers), 0));
@@ -306,8 +307,8 @@ TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_SmallBodyInMemory) {
TEST(HttpStreamParser, ShouldMergeRequestHeadersAndBody_LargeBodyInMemory) {
std::vector<std::unique_ptr<UploadElementReader>> element_readers;
const std::string payload(10000, 'a'); // 'a' x 10000.
- element_readers.push_back(base::WrapUnique(
- new UploadBytesElementReader(payload.data(), payload.size())));
+ element_readers.push_back(base::MakeUnique<UploadBytesElementReader>(
+ payload.data(), payload.size()));
std::unique_ptr<UploadDataStream> body(
new ElementsUploadDataStream(std::move(element_readers), 0));
@@ -451,7 +452,7 @@ TEST(HttpStreamParser, SentBytesPost) {
std::vector<std::unique_ptr<UploadElementReader>> element_readers;
element_readers.push_back(
- base::WrapUnique(new UploadBytesElementReader("hello world!", 12)));
+ base::MakeUnique<UploadBytesElementReader>("hello world!", 12));
ElementsUploadDataStream upload_data_stream(std::move(element_readers), 0);
ASSERT_THAT(upload_data_stream.Init(TestCompletionCallback().callback(),
BoundNetLog()),
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller_unittest.cc ('k') | net/http/mock_http_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698