Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: net/http/http_stream_factory_impl_job_controller_unittest.cc

Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_stream_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job_controller_unittest.cc
diff --git a/net/http/http_stream_factory_impl_job_controller_unittest.cc b/net/http/http_stream_factory_impl_job_controller_unittest.cc
index ccbcc268e4a6ff5c994e82ad8500ba092795f98b..63d22fb4373b9f15ba45e25ee7c24636a9417414 100644
--- a/net/http/http_stream_factory_impl_job_controller_unittest.cc
+++ b/net/http/http_stream_factory_impl_job_controller_unittest.cc
@@ -174,9 +174,9 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// Use asynchronous proxy resolver.
MockAsyncProxyResolverFactory* proxy_resolver_factory =
new MockAsyncProxyResolverFactory(false);
- session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
- base::WrapUnique(proxy_resolver_factory), nullptr));
+ session_deps_.proxy_service.reset(
+ new ProxyService(base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
+ base::WrapUnique(proxy_resolver_factory), nullptr));
Initialize(false);
HttpRequestInfo request_info;
@@ -204,9 +204,9 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// Use asynchronous proxy resolver.
MockAsyncProxyResolverFactory* proxy_resolver_factory =
new MockAsyncProxyResolverFactory(false);
- session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
- base::WrapUnique(proxy_resolver_factory), nullptr));
+ session_deps_.proxy_service.reset(
+ new ProxyService(base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
+ base::WrapUnique(proxy_resolver_factory), nullptr));
Initialize(false);
HttpRequestInfo request_info;
@@ -271,9 +271,9 @@ TEST_F(HttpStreamFactoryImplJobControllerTest, OnStreamFailedForBothJobs) {
// Use asynchronous proxy resolver.
MockAsyncProxyResolverFactory* proxy_resolver_factory =
new MockAsyncProxyResolverFactory(false);
- session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
- base::WrapUnique(proxy_resolver_factory), nullptr));
+ session_deps_.proxy_service.reset(
+ new ProxyService(base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
+ base::WrapUnique(proxy_resolver_factory), nullptr));
Initialize(false);
HttpRequestInfo request_info;
@@ -315,9 +315,9 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// Use asynchronous proxy resolver.
MockAsyncProxyResolverFactory* proxy_resolver_factory =
new MockAsyncProxyResolverFactory(false);
- session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
- base::WrapUnique(proxy_resolver_factory), nullptr));
+ session_deps_.proxy_service.reset(
+ new ProxyService(base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
+ base::WrapUnique(proxy_resolver_factory), nullptr));
Initialize(false);
HttpRequestInfo request_info;
@@ -367,9 +367,9 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// Use asynchronous proxy resolver.
MockAsyncProxyResolverFactory* proxy_resolver_factory =
new MockAsyncProxyResolverFactory(false);
- session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
- base::WrapUnique(proxy_resolver_factory), nullptr));
+ session_deps_.proxy_service.reset(
+ new ProxyService(base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
+ base::WrapUnique(proxy_resolver_factory), nullptr));
Initialize(false);
HttpRequestInfo request_info;
@@ -466,7 +466,7 @@ TEST_F(HttpStreamFactoryImplJobControllerTest, DoNotResumeMainJobBeforeWait) {
proxy_config.set_auto_detect(true);
proxy_config.set_pac_mandatory(true);
session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
+ base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
base::WrapUnique(new FailingProxyResolverFactory), nullptr));
Initialize(false);
@@ -529,9 +529,9 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// Use asynchronous proxy resolver.
MockAsyncProxyResolverFactory* proxy_resolver_factory =
new MockAsyncProxyResolverFactory(false);
- session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
- base::WrapUnique(proxy_resolver_factory), nullptr));
+ session_deps_.proxy_service.reset(
+ new ProxyService(base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
+ base::WrapUnique(proxy_resolver_factory), nullptr));
HangingResolver* host_resolver = new HangingResolver();
session_deps_.host_resolver.reset(host_resolver);
@@ -597,9 +597,9 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// Use asynchronous proxy resolver.
MockAsyncProxyResolverFactory* proxy_resolver_factory =
new MockAsyncProxyResolverFactory(false);
- session_deps_.proxy_service.reset(new ProxyService(
- base::WrapUnique(new ProxyConfigServiceFixed(proxy_config)),
- base::WrapUnique(proxy_resolver_factory), nullptr));
+ session_deps_.proxy_service.reset(
+ new ProxyService(base::MakeUnique<ProxyConfigServiceFixed>(proxy_config),
+ base::WrapUnique(proxy_resolver_factory), nullptr));
Initialize(false);
« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_stream_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698