components/password_manager/core/browser/password_store.cc - Issue 2259813002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 2259813002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | components/password_manager/core/browser/password_store_default_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store.cc

diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc

index 74146690c3ec93361e63ee73969133df1ed2766e..e128c7003b9181e1d5831c57a36b8dd6ac25698a 100644

--- a/components/password_manager/core/browser/password_store.cc

+++ b/components/password_manager/core/browser/password_store.cc

@@ -67,8 +67,9 @@ void PasswordStore::GetLoginsRequest::NotifyConsumerWithResults(

void PasswordStore::GetLoginsRequest::NotifyWithSiteStatistics(

std::vector<std::unique_ptr<InteractionsStats>> stats) {

- auto passed_stats(base::WrapUnique(

- new std::vector<std::unique_ptr<InteractionsStats>>(std::move(stats))));

+ auto passed_stats(

+ base::MakeUnique<std::vector<std::unique_ptr<InteractionsStats>>>(

+ std::move(stats)));

origin_task_runner_->PostTask(

FROM_HERE, base::Bind(&PasswordStoreConsumer::OnGetSiteStatistics,

consumer_weak_, base::Passed(&passed_stats)));