Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2259813002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 6a9c10ff37dfa9c79f6eb3177a9527fc7e5e911c..d3d2d587a23587951aec18c9f98dc372348e66c2 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -229,9 +229,9 @@ void PasswordManager::SetGenerationElementAndReasonForForm(
// If there is no corresponding PasswordFormManager, we create one. This is
// not the common case, and should only happen when there is a bug in our
// ability to detect forms.
- auto manager = base::WrapUnique(new PasswordFormManager(
+ auto manager = base::MakeUnique<PasswordFormManager>(
this, client_, driver->AsWeakPtr(), form,
- base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore()))));
+ base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore())));
pending_login_managers_.push_back(std::move(manager));
}
@@ -519,11 +519,11 @@ void PasswordManager::CreatePendingLoginManagers(
if (logger)
logger->LogFormSignatures(Logger::STRING_ADDING_SIGNATURE, *iter);
- auto manager = base::WrapUnique(new PasswordFormManager(
+ auto manager = base::MakeUnique<PasswordFormManager>(
this, client_,
(driver ? driver->AsWeakPtr() : base::WeakPtr<PasswordManagerDriver>()),
*iter,
- base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore()))));
+ base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore())));
pending_login_managers_.push_back(std::move(manager));
}

Powered by Google App Engine
This is Rietveld 408576698